Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Doesn't Work in 1.20.1 And Later Versions. #667

Open
KnightMithridatis opened this issue Dec 29, 2024 · 23 comments
Open

Tag Doesn't Work in 1.20.1 And Later Versions. #667

KnightMithridatis opened this issue Dec 29, 2024 · 23 comments

Comments

@KnightMithridatis
Copy link

For some reason, I cannot assign tags to blocks in version 1.20.1. So I tried all kinds of commands. For example, I set a tag to put 10 coals in the furnace. Unfortunately it didn't spawn.
2024-12-29 154915
2024-12-29 154951
2024-12-29 155037

@KnightMithridatis
Copy link
Author

The problem is definitely related to the Lost Cities mod. Maybe the Lost Cities tag code may be incompatible with version +1.20.

@KnightMithridatis
Copy link
Author

Because in version 1.18.2, I can assign tags to blocks without any problems.

@McJty
Copy link
Collaborator

McJty commented Dec 30, 2024

You cannot assign tags to blocks within an array like you're trying to do. i.e. if you have a palette entry with multiple possible blocks then those blocks cannot have tags. That's simply not supported

@KnightMithridatis
Copy link
Author

You cannot assign tags to blocks within an array like you're trying to do. i.e. if you have a palette entry with multiple possible blocks then those blocks cannot have tags. That's simply not supported

So, is there another way to add tags in 1.20.1 Lost Cities mod? Because it worked in 1.18.2. I can't even put coal in furnace anymore in 1.20.1. It's a bit absurd.

@McJty
Copy link
Collaborator

McJty commented Dec 30, 2024

No, this didn't work in 1.18.2 either. This hasn't changed. Lost Cities has never been able to assign tags to blocks that are part of a single character block array. You can assign tags to blocks that are independent of course. Both in 1.18 and 1.20. But not to blocks in a randomizer

@KnightMithridatis
Copy link
Author

No, this didn't work in 1.18.2 either. This hasn't changed. Lost Cities has never been able to assign tags to blocks that are part of a single character block array. You can assign tags to blocks that are independent of course. Both in 1.18 and 1.20. But not to blocks in a randomizer

It works on Lost Cities version 1.18.2. I'm making highways with TrafficCraft. I need to adjust the color of the blocks with tags. As evidence I can offer this:
2024-12-30 092523
2024-12-30 092611

@McJty
Copy link
Collaborator

McJty commented Dec 30, 2024

You don't understand. That's different. There you are using the tag on a block that has no variations. That character is always assigned to that block. And then tags work. You cannot use tags on blocks that have variations. i..e multiple possible blocks for the same palette entry

@KnightMithridatis
Copy link
Author

You don't understand. That's different. There you are using the tag on a block that has no variations. That character is always assigned to that block. And then tags work. You cannot use tags on blocks that have variations. i..e multiple possible blocks for the same palette entry

So I understand you won't help.

@McJty
Copy link
Collaborator

McJty commented Dec 30, 2024

What? I'm trying to help. I'm explaining what's going on. Tags work on standalone blocks. They don't work on randomized blocks. That was also like that in 1.18. That code literally hasn't changed

@McJty
Copy link
Collaborator

McJty commented Dec 30, 2024

We have just confirmed that tags on a standalone block still work. Like the ";" that is defined in default.json from Lost Cities itself

@KnightMithridatis
Copy link
Author

We have just confirmed that tags on a standalone block still work. Like the ";" that is defined in default.json from Lost Cities itself

So can you give me a code example?

@KnightMithridatis
Copy link
Author

We have just confirmed that tags on a standalone block still work. Like the ";" that is defined in default.json from Lost Cities itself

We have just confirmed that tags on a standalone block still work. Like the ";" that is defined in default.json from Lost Cities itself

{
"char": ";",
"block": "minecraft:furnace",
"damaged": "minecraft:iron_bars",
"tag": {
"Items": [
{
"Slot": 0,
"id": "minecraft:coal",
"Count": 10
}
]
}
},

I assigned this to the code in default.json, but it still didn't work.

@McJty
Copy link
Collaborator

McJty commented Dec 30, 2024

That entry is by defaulit already present in default.json (from Lost Cities). Not sure why it isn't working for you though

@KnightMithridatis
Copy link
Author

That entry is by defaulit already present in default.json (from Lost Cities). Not sure why it isn't working for you though

I did it via kubejs. But kubejs works.

@McJty
Copy link
Collaborator

McJty commented Dec 30, 2024

Can you show me your datapack where you are trying to do this?

@KnightMithridatis
Copy link
Author

Can you show me your datapack where you are trying to do this?

I'm trying another way. If it doesn't work, I'll write.

@KnightMithridatis
Copy link
Author

Can you show me your datapack where you are trying to do this?

I placed a separate generic block in default.json. It worked. Now I will try it for trafficcraft blocks.

2024-12-30 105150

2024-12-30 105151

@KnightMithridatis
Copy link
Author

Can you show me your datapack where you are trying to do this?

Unfortunately, whatever you did to the code in Lost Cities version 1.20-7.3.5. I can't tag the trafficcraft asphalt pattern block. However, I can assign tags in Lost Cities version 1.20-7.1.8. I share the pictures below, one by one.
Ekran görüntüsü 2024-12-30 133643
Ekran görüntüsü 2024-12-30 133413
Ekran görüntüsü 2024-12-30 133606

@KnightMithridatis
Copy link
Author

In short, the problem isn't related to TrafficCraft. There is a problem with Lost Cities version 7.3.5.

@McJty
Copy link
Collaborator

McJty commented Dec 30, 2024

Well I can't reproduce the problem with the latest version. I would still like to see your datapack

@KnightMithridatis
Copy link
Author

KnightMithridatis commented Dec 30, 2024

Well I can't reproduce the problem with the latest version. I would still like to see your datapack

So how can I get the datapack? What exactly do you want? I think you want the kubejs\data\lostcities folder.

@McJty
Copy link
Collaborator

McJty commented Dec 30, 2024

Well it's your datapack. So I assume you know how to get it? It's me that need to get it from you :-)

@KnightMithridatis
Copy link
Author

Well it's your datapack. So I assume you know how to get it? It's me that need to get it from you :-)

I'll send you the .jar files of the mods I used. I will also send the kubejs\data\lostcities folder. Because I've never had anything to do with datapack. You can test it yourself by creating a world. You can find trafficcraft blocks in buildings. Test it first with 7.1.8 and then with 7.3.5.

Mods for 1.20.1 forge.zip
kubejs.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants