Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monochromator_bent not working for negative bending radii, and other configurations. Also yielding wrong results with multiple lamella. #1720

Open
Lomholy opened this issue Sep 27, 2024 · 1 comment

Comments

@Lomholy
Copy link
Contributor

Lomholy commented Sep 27, 2024

When setting a negative bending radius an error is currently given, but many other configurations that should be working with the component have not been tested and are also probable to fail without proper warning.

Using multiple lamella produces different results then expected, so care should be taken with results generated from anything that is not just a single slab, reflecting neutrons from the front, such as in the "Test_monochromator_bent.instr".

Me and Jan will work on fixing these problems, and once done, include a list in some way or form, of the configurations that we have tested it and agreed that it works properly in.

@willend
Copy link
Contributor

willend commented Sep 28, 2024

@Lomholy thanks for reporting/documenting this.

Once you have fixed the bugs and decided on the best "test scenarios", I can recommend including
%Example lines in the instrument headers (i.e. in ILL_SALSA and Test_Monochromator_bent - then these will ensure tests / reproducibility going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants