Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: Missing item textures for Chipped doors on 1.21.x (all loaders, all modded wood types) #796

Closed
4 tasks done
murderspagurder opened this issue Jan 26, 2025 · 4 comments
Labels
1.21.1-NEOFORGE Minecraft Version bug Something isn't working status: done The issue is finished & it'll be in next version
Milestone

Comments

@murderspagurder
Copy link

Code of Conduct

  • Always check you are using the latest version of the mods and its dependencies
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)

1.21.1 - NEOFORGE

EveryCompat Version

everycompat-1.21-2.9.2-neoforge

Moonlight Lib Version

moonlight-1.21.2.17.18-neoforge

Issue with mods

  • Oh The Biomes We've Gone 2.3.2
  • Chipped 4.0.2

Issue Detail

All Chipped doors using Oh The Biomes We've Gone wood are missing textures in the inventory and as an item. The doors do render properly when placed. (NOTE: This also affects Fabric with same mod versions). Redwood as an example- this affects all biomeswevegone wood types:

Image

Image

OPTIONAL: Latest.log | Crash-report Attachment

No response

OPTIONAL: To Produce

No response

@murderspagurder murderspagurder added the bug Something isn't working label Jan 26, 2025
@github-actions github-actions bot added the 1.21.1-NEOFORGE Minecraft Version label Jan 26, 2025
@murderspagurder
Copy link
Author

After doing some further testing, this appears to affect all chipped doors using non-vanilla wood types on 1.21.x. This includes Biomes We've Gone, Biomes O' Plenty, and Regions Unexplored. I suspect this may be related to the addModelTransform (and/or recent moonlight lib versions) method being called in ChippedModule, as it stands out as the most stark difference between 1.20.x and 1.21.x versions of the code. I'm continuing to tinker and attempt to potentially patch, but I'm not intimately familiar with the Every Compat codebase.

@murderspagurder murderspagurder changed the title [🐞]: Missing item textures for Chipped doors using Oh The Biomes We've Gone wood on NeoForge and Fabric 1.21.1 [🐞]: Missing item textures for Chipped doors on 1.21.x (all loaders, all modded wood types) Jan 28, 2025
@Xelbayria
Copy link
Collaborator

Xelbayria commented Jan 28, 2025

Ah thanks to your information, i remember the problem. I've fixed it in 1.20.1 before.

I'll apply the fix to 1.21 this week.

@Xelbayria
Copy link
Collaborator

FIXED in v2.9.3

@Xelbayria Xelbayria added the status: done The issue is finished & it'll be in next version label Jan 28, 2025
@Xelbayria Xelbayria added this to the 1.21-2.9.3 milestone Jan 28, 2025
@murderspagurder
Copy link
Author

@Xelbayria Thanks for the fix, you saved me hours of teeth pulling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1-NEOFORGE Minecraft Version bug Something isn't working status: done The issue is finished & it'll be in next version
Projects
None yet
Development

No branches or pull requests

2 participants