Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

add error message when b/b_old is -inf/-inf #41

Closed

Conversation

LittleBeannie
Copy link
Collaborator

No description provided.

@LittleBeannie LittleBeannie linked an issue Aug 8, 2022 that may be closed by this pull request
@nanxstats
Copy link
Collaborator

@LittleBeannie Should this be merged or are we waiting for more approvals?

@LittleBeannie
Copy link
Collaborator Author

@LittleBeannie Should this be merged or are we waiting for more approvals?

Yeah, more detailed checks are needed here. I will follow up.

@elong0527
Copy link
Collaborator

Seems we can merge it only after @keaven approve. It might delay our test development. Could we add Nan and Myself as authorized approver?

@nanxstats
Copy link
Collaborator

Seems we can merge it only after @keaven approve. It might delay our test development. Could we add Nan and Myself as authorized approver?

It looks like I have the permission to merge this, but I'm waiting for Yujie's follow up.

@LittleBeannie
Copy link
Collaborator Author

I discussed this with Keaven before, it should work but it gives errors

@nanxstats
Copy link
Collaborator

I'm closing this PR as we have merged gsdmvn into gsDesign2 for a while and we are archiving this repo. This particular issue will be resolved (or has already been resolved) in gsDesign2.

@nanxstats nanxstats closed this Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gs_spending_bound bug when IA is close to FA
3 participants