You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The package currently used to support QR-based devices is external to MetaMask organization, and doesn't strictly follow our conventions and types for our Keyring classes.
Moreover, its current implementation includes functionality for managing UI modals related to pairing and signing.
We should evaluate the creation of an internal QRKeyring package with a simplified implementation (no UI management) with the following acceptance criteria:
The package must have full package-level test coverage and should be easily testable at client level with e2e
A Keyring Bridge is a keyring extension that can be optionally added in case the keyring structure doesn't allow easy e2e testing. This should not be needed as there is no communication transport besides QR-based messages, which can be easily mocked.
The text was updated successfully, but these errors were encountered:
The package currently used to support QR-based devices is external to MetaMask organization, and doesn't strictly follow our conventions and types for our Keyring classes.
Moreover, its current implementation includes functionality for managing UI modals related to pairing and signing.
We should evaluate the creation of an internal QRKeyring package with a simplified implementation (no UI management) with the following acceptance criteria:
QRKeyring
class extends the Keyring typeQRKeyring
class supports initialization with a CBOR string compatible with QR-based devices currently supported by MetaMask clientsQRKeyring
class can be used to derive the same accounts that are currently derivable with @keystonehq/metamask-airgapped-keyringQRKeyring
class must support the deserialization of a state coming from @keystonehq/metamask-airgapped-keyringThe text was updated successfully, but these errors were encountered: