diff --git a/CHANGELOG.md b/CHANGELOG.md index af24c5f1d..4ce190bee 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,9 @@ # Changelog and release notes - +## Unreleased +### Fixes +- fix leaking resolver source code in `MissingSubscriptionTopicsError` error message (#489) ## v0.17.5 ### Features diff --git a/src/errors/MissingSubscriptionTopicsError.ts b/src/errors/MissingSubscriptionTopicsError.ts index 0d2f772da..a51b17810 100644 --- a/src/errors/MissingSubscriptionTopicsError.ts +++ b/src/errors/MissingSubscriptionTopicsError.ts @@ -1,6 +1,6 @@ export class MissingSubscriptionTopicsError extends Error { constructor(target: Function, methodName: string) { - super(`${target}#${methodName} subscription has no provided topics!`); + super(`${target.name}#${methodName} subscription has no provided topics!`); Object.setPrototypeOf(this, new.target.prototype); } diff --git a/tests/functional/subscriptions.ts b/tests/functional/subscriptions.ts index 3016cbf99..4ff46d9b8 100644 --- a/tests/functional/subscriptions.ts +++ b/tests/functional/subscriptions.ts @@ -535,7 +535,7 @@ describe("Subscriptions", () => { it("should throw error while passing empty topics array to Subscription", async () => { getMetadataStorage().clear(); - expect.assertions(4); + expect.assertions(5); try { @ObjectType() class SampleObject { @@ -569,6 +569,7 @@ describe("Subscriptions", () => { expect(err).toBeInstanceOf(MissingSubscriptionTopicsError); expect(err.message).toContain("SampleResolver"); expect(err.message).toContain("sampleSubscription"); + expect(err.message).not.toContain("class SampleResolver"); } });