From cff2e98a3ca37b60a436857f9817f9df6145ac53 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 1 Feb 2024 22:32:55 +0000 Subject: [PATCH 1/8] Bump actions/download-artifact from 3 to 4 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/test_docker_debian_codename_sub.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_docker_debian_codename_sub.yml b/.github/workflows/test_docker_debian_codename_sub.yml index b018afaf5..e4d190836 100644 --- a/.github/workflows/test_docker_debian_codename_sub.yml +++ b/.github/workflows/test_docker_debian_codename_sub.yml @@ -150,7 +150,7 @@ jobs: uses: docker/setup-buildx-action@v3.0.0 - name: Artifact Download Docker Image - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: ${{ needs.build.outputs.image_file_name }} From fc56769db87157e350d6ab3aba31d694f910f34e Mon Sep 17 00:00:00 2001 From: Alvin Schiller <103769832+AlvinSchiller@users.noreply.github.com> Date: Sun, 4 Feb 2024 22:36:16 +0100 Subject: [PATCH 2/8] Bump actions/upload-artifact from 3 to 4 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- .github/workflows/test_docker_debian_codename_sub.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_docker_debian_codename_sub.yml b/.github/workflows/test_docker_debian_codename_sub.yml index e4d190836..b5da1947e 100644 --- a/.github/workflows/test_docker_debian_codename_sub.yml +++ b/.github/workflows/test_docker_debian_codename_sub.yml @@ -124,7 +124,7 @@ jobs: BASE_TEST_IMAGE=${{ steps.vars.outputs.image_tag_name_local_base }} - name: Artifact Upload Docker Image - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ${{ steps.vars.outputs.image_file_name }} path: ${{ steps.vars.outputs.image_file_path }} From c2d60cb81f1af03bda9c2ebd8c4d2f16f5831d7a Mon Sep 17 00:00:00 2001 From: Alvin Schiller <103769832+AlvinSchiller@users.noreply.github.com> Date: Sun, 4 Feb 2024 22:36:50 +0100 Subject: [PATCH 3/8] Bump geekyeggo/delete-artifact from 2 to 4 --- .github/workflows/test_docker_debian_codename_sub.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_docker_debian_codename_sub.yml b/.github/workflows/test_docker_debian_codename_sub.yml index b5da1947e..638612c46 100644 --- a/.github/workflows/test_docker_debian_codename_sub.yml +++ b/.github/workflows/test_docker_debian_codename_sub.yml @@ -177,6 +177,6 @@ jobs: steps: - name: Artifact Delete Docker Image - uses: geekyeggo/delete-artifact@v2 + uses: geekyeggo/delete-artifact@v4 with: name: ${{ needs.build.outputs.image_file_name }} From 98f65c91ae97b34b5b7a2807c8799c2d45a4997d Mon Sep 17 00:00:00 2001 From: Alvin Schiller <103769832+AlvinSchiller@users.noreply.github.com> Date: Sun, 4 Feb 2024 23:41:38 +0100 Subject: [PATCH 4/8] add write permission for artifact deletion --- .github/workflows/test_docker_debian.yml | 2 ++ .github/workflows/test_docker_debian_codename_sub.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/test_docker_debian.yml b/.github/workflows/test_docker_debian.yml index 1395137a0..c775ce860 100644 --- a/.github/workflows/test_docker_debian.yml +++ b/.github/workflows/test_docker_debian.yml @@ -41,6 +41,8 @@ jobs: # Build container and run tests run: + permissions: + actions: write name: ${{ matrix.debian_codename }} strategy: fail-fast: false diff --git a/.github/workflows/test_docker_debian_codename_sub.yml b/.github/workflows/test_docker_debian_codename_sub.yml index 638612c46..8890bc24f 100644 --- a/.github/workflows/test_docker_debian_codename_sub.yml +++ b/.github/workflows/test_docker_debian_codename_sub.yml @@ -170,6 +170,8 @@ jobs: # cleanup after test execution cleanup: + permissions: + actions: write # run only if tests didn't fail: keep the artifact to make job reruns possible if: ${{ !failure() }} needs: [build, test] From 59866e26a1a5f7c02975bacaf6d8dbcfd54fe7c4 Mon Sep 17 00:00:00 2001 From: Alvin Schiller <103769832+AlvinSchiller@users.noreply.github.com> Date: Mon, 5 Feb 2024 01:26:37 +0100 Subject: [PATCH 5/8] ignore fails for artifact deletion --- .github/workflows/test_docker_debian_codename_sub.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test_docker_debian_codename_sub.yml b/.github/workflows/test_docker_debian_codename_sub.yml index 8890bc24f..1a902f961 100644 --- a/.github/workflows/test_docker_debian_codename_sub.yml +++ b/.github/workflows/test_docker_debian_codename_sub.yml @@ -182,3 +182,5 @@ jobs: uses: geekyeggo/delete-artifact@v4 with: name: ${{ needs.build.outputs.image_file_name }} + # Ignore failes. On PRs no write persmissions are granted. + failOnError: false From 4239905739fd932a14ccedac2addd89140d2a010 Mon Sep 17 00:00:00 2001 From: Alvin Schiller <103769832+AlvinSchiller@users.noreply.github.com> Date: Mon, 5 Feb 2024 07:44:09 +0100 Subject: [PATCH 6/8] REVERT: ignore fails for artifact deletion --- .github/workflows/test_docker_debian_codename_sub.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/test_docker_debian_codename_sub.yml b/.github/workflows/test_docker_debian_codename_sub.yml index 1a902f961..8890bc24f 100644 --- a/.github/workflows/test_docker_debian_codename_sub.yml +++ b/.github/workflows/test_docker_debian_codename_sub.yml @@ -182,5 +182,3 @@ jobs: uses: geekyeggo/delete-artifact@v4 with: name: ${{ needs.build.outputs.image_file_name }} - # Ignore failes. On PRs no write persmissions are granted. - failOnError: false From b3fba0c8755712ef6dd86a7f780b8af555516c80 Mon Sep 17 00:00:00 2001 From: Alvin Schiller <103769832+AlvinSchiller@users.noreply.github.com> Date: Mon, 5 Feb 2024 07:44:46 +0100 Subject: [PATCH 7/8] REVERT: add write permission for artifact deletion --- .github/workflows/test_docker_debian.yml | 2 -- .github/workflows/test_docker_debian_codename_sub.yml | 2 -- 2 files changed, 4 deletions(-) diff --git a/.github/workflows/test_docker_debian.yml b/.github/workflows/test_docker_debian.yml index c775ce860..1395137a0 100644 --- a/.github/workflows/test_docker_debian.yml +++ b/.github/workflows/test_docker_debian.yml @@ -41,8 +41,6 @@ jobs: # Build container and run tests run: - permissions: - actions: write name: ${{ matrix.debian_codename }} strategy: fail-fast: false diff --git a/.github/workflows/test_docker_debian_codename_sub.yml b/.github/workflows/test_docker_debian_codename_sub.yml index 8890bc24f..638612c46 100644 --- a/.github/workflows/test_docker_debian_codename_sub.yml +++ b/.github/workflows/test_docker_debian_codename_sub.yml @@ -170,8 +170,6 @@ jobs: # cleanup after test execution cleanup: - permissions: - actions: write # run only if tests didn't fail: keep the artifact to make job reruns possible if: ${{ !failure() }} needs: [build, test] From f92e2fd0bf1cde27f237b38ad53192b5a31eda38 Mon Sep 17 00:00:00 2001 From: Alvin Schiller <103769832+AlvinSchiller@users.noreply.github.com> Date: Mon, 5 Feb 2024 07:46:08 +0100 Subject: [PATCH 8/8] remove cleanup stage for now --- .../test_docker_debian_codename_sub.yml | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test_docker_debian_codename_sub.yml b/.github/workflows/test_docker_debian_codename_sub.yml index 638612c46..451fb96b5 100644 --- a/.github/workflows/test_docker_debian_codename_sub.yml +++ b/.github/workflows/test_docker_debian_codename_sub.yml @@ -168,15 +168,15 @@ jobs: args: | ./${{ matrix.test_script }} - # cleanup after test execution - cleanup: - # run only if tests didn't fail: keep the artifact to make job reruns possible - if: ${{ !failure() }} - needs: [build, test] - runs-on: ${{ inputs.runs_on }} - - steps: - - name: Artifact Delete Docker Image - uses: geekyeggo/delete-artifact@v4 - with: - name: ${{ needs.build.outputs.image_file_name }} + ## cleanup after test execution + # cleanup: + ## run only if tests didn't fail: keep the artifact to make job reruns possible + #if: ${{ !failure() }} + #needs: [build, test] + #runs-on: ${{ inputs.runs_on }} + # + #steps: + # - name: Artifact Delete Docker Image + # uses: geekyeggo/delete-artifact@v4 + # with: + # name: ${{ needs.build.outputs.image_file_name }}