Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause tokens by default upon deploy #67

Closed
kantp opened this issue Jun 26, 2024 · 0 comments · Fixed by #85
Closed

Pause tokens by default upon deploy #67

kantp opened this issue Jun 26, 2024 · 0 comments · Fixed by #85
Assignees
@kantp
Labels
audit Addresses findings from the audit warning

Comments

@kantp
Copy link
Collaborator

kantp commented Jun 26, 2024

This is a safer default option, in particular if the deploy of admin contract and token contract is not atomic.

Token issuers should be able to start the tokens unpaused, but that should be a conscious choice.
@kantp kantp added the audit Addresses findings from the audit label Jun 26, 2024
@kantp kantp moved this to Todo in Fungible Token Audit Jul 2, 2024
@kantp kantp moved this from Todo to In Progress in Fungible Token Audit Jul 3, 2024
kantp added a commit that referenced this issue Jul 4, 2024
@kantp
Adapt tests to having tokens start paused
8a3534f 
- Added a test that tokens indeed are not minted before calling `resume()`
- Make sure the existing tests pass, by resuming the tokens

Fixes #67
@kantp kantp moved this from In Progress to Pending Review in Fungible Token Audit Jul 4, 2024
@kantp kantp linked a pull request Jul 4, 2024 that will close this issue
Pause tokens by default during deployment #85
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 4, 2024
@kantp
Adapt tests to having tokens start paused
ee4fc66 
- Added a test that tokens indeed are not minted before calling `resume()`
- Make sure the existing tests pass, by resuming the tokens

Fixes #67
@kantp kantp closed this as completed in #85 Jul 4, 2024
@github-project-automation github-project-automation bot moved this from Pending Review to Done in Fungible Token Audit Jul 4, 2024
@kantp kantp self-assigned this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kantp kantp

Labels
audit Addresses findings from the audit warning
Projects
Fungible Token Audit
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pause tokens by default during deployment MinaFoundation/mina-fungible-token
1 participant
@kantp