Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Rosetta integration tests back to use mainstream rosetta-cli. #12509

Open
Sventimir opened this issue Jan 13, 2023 · 1 comment
Open

Comments

@Sventimir
Copy link
Contributor

At the moment our rosetta-cli test contain stake delegations, which are not yet handled by mainteream rosetta-cli. To have them supported, we made changes to rosetta-sdk-go and until they're merged, we have to use our fork of rosetta-sdk-go in our CI. Once our contribution is merged and released, we need to switch our CI to use mainstream rosetta-cli for testing.

  • The pull request we're waiting for is: #464
  • When it's merged we can switch to pulling master branch of rosetta-sdk-go in our tests
  • When these changes are released, we can pull main-line rosetta-cli binary rather than compile it from sources.
@kantp
Copy link
Member

kantp commented Feb 6, 2023

I got feedback from Coinbase on the PR:
There are two places where Mina is mentioned in the code:

We'd need to remove those in order to get the PR merged upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants