-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert code to ES6 and add a transpile build step #109
Comments
This sounds sensible, if this still ends up using Browserify with the addition of the Babelify transform, you could add the following to {
"browserify": {
"transform": ["babelify"]
}
} |
Another possibility is to include in npm package compiled files (but ignore those in git). |
Webpack? |
@phifa I believe Webpack is overkill for a library like Pjax. Webpack is more suited for a webapp with different types of assets or multiple entry points. For Pjax, Babel and Browserify should be fine. |
Rollup should be a good candidate. |
Do we even need Rollup? |
I just know that Rollup is nice for library authors |
True. I'll have to look into the differences between Rollup and Browserify. |
@MoOx What browserlist settings do you think we should use for Babel? |
No idea what is best to use. Keep defaults? |
As mentioned here, I think this should wait until we finish fixing all the existing issues, so we don't cause any conflicts.
The text was updated successfully, but these errors were encountered: