Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert code to ES6 and add a transpile build step #109

Open
BehindTheMath opened this issue Jan 19, 2018 · 10 comments
Open

Convert code to ES6 and add a transpile build step #109

BehindTheMath opened this issue Jan 19, 2018 · 10 comments
Milestone

Comments

@BehindTheMath
Copy link
Collaborator

BehindTheMath commented Jan 19, 2018

As mentioned here, I think this should wait until we finish fixing all the existing issues, so we don't cause any conflicts.

@robinnorth
Copy link
Collaborator

This sounds sensible, if this still ends up using Browserify with the addition of the Babelify transform, you could add the following topackage.json to allow people bundling the npm package through Browserify (my usage) to get transpiled output as well (Browserify won't transform anything under node_modules by default):

{
  "browserify": {
    "transform": ["babelify"]
  }
}

@MoOx
Copy link
Owner

MoOx commented Jan 22, 2018

Another possibility is to include in npm package compiled files (but ignore those in git).

@BehindTheMath BehindTheMath added this to the 0.2.6 milestone Jan 24, 2018
@phifa
Copy link

phifa commented Feb 6, 2018

Webpack?

@BehindTheMath
Copy link
Collaborator Author

@phifa I believe Webpack is overkill for a library like Pjax. Webpack is more suited for a webapp with different types of assets or multiple entry points. For Pjax, Babel and Browserify should be fine.

@MoOx
Copy link
Owner

MoOx commented Feb 7, 2018

Rollup should be a good candidate.

@BehindTheMath
Copy link
Collaborator Author

Do we even need Rollup?

@MoOx
Copy link
Owner

MoOx commented Feb 7, 2018

I just know that Rollup is nice for library authors

@BehindTheMath
Copy link
Collaborator Author

True. I'll have to look into the differences between Rollup and Browserify.

@BehindTheMath
Copy link
Collaborator Author

@MoOx What browserlist settings do you think we should use for Babel?

@MoOx
Copy link
Owner

MoOx commented Mar 4, 2019

No idea what is best to use. Keep defaults?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants