analytics function doesn't send t object

[rstacruz]

Using v0.1.4, I'm getting this error:

                this.options.analytics = this.options.analytics || function(t) {
                    window._gaq && _gaq.push(["_trackPageview"]),
                    window.ga && ga("send", "pageview", {
                        page: t.url, # Uncaught TypeError: Cannot read property 'url' of undefined
                        title: t.title
                    })
                }

[MoOx]

where do you find this t thing ? I am not using this lib anymore and struggle to find something about it, sorry :/

[rstacruz]

It's from here:

pjax/lib/proto/parse-options.js

Lines 10 to 20 in 6eafcf8

	this.options.analytics = this.options.analytics || function(options) {
	// options.backward or options.foward can be true or undefined
	// by default, we do track back/foward hit
	// https://productforums.google.com/forum/#!topic/analytics/WVwMDjLhXYk
	if (window._gaq) {
	_gaq.push(["_trackPageview"])
	}
	if (window.ga) {
	ga("send", "pageview", {page: options.url, title: options.title})
	}
	}

[MoOx]

From what I can read, indeed it's not send. Not sure why I did that :(

[MoOx]

This lib wasn't tested before 0.2, but it seems 0.2 is not working and nobody wants to contribute :/

[rstacruz]

any pointers on how we can fix 0.2?

[MoOx]

I "just" splited the code into small pieces, in order to facilitate testing. It seems tests are broken and I think I didn't finish a test or something like that. Should not be a big deal, but "we" just need to find what is going wrong :/

[MoOx]

Maybe you can try "npm install & npm test" and see what happens? :D

[MoOx]

I can add you as a collab if you want

[rstacruz]

it breaks because one test has t.fail in it:

https://github.com/MoOx/pjax/blob/master/tests/lib/switch-selectors.js#L6

no indication as to why it's made to fail though.

edit: its introduced here at #20

[darylteo]

It's made to fail because there is no test written for it yet.

Switch Selectors also seems to be broken with issue #46 so I will look to fix that one and implement tests for it.

EDIT:
PR #52 patches switch-selectors.js test

[MoOx]

So is this fixed now (sorry I am lazy)?

[darylteo]

No I only fixed the failing test.

Not sure what the issue is in this one because the line of code referenced
doesn't seem to exist in the code base anymore.
On Tue, Jan 5, 2016 at 5:20 PM Maxime Thirouin [email protected]
wrote:

So is this fixed now (sorry I am lazy)?

—
Reply to this email directly or view it on GitHub
#43 (comment).

[rstacruz]

@MoOx, on a side note, may i ask why you're not using this library anymore?

for me: the alternatives are to use jquery.pjax and wiselinks, both of which rely on jQuery, which I'd prefer not to be a dependency.

[MoOx]

I now only build webapps with React (for the last two years) :)

[rstacruz]

ah, haha, right

[darylteo]

What about us poor legacy maintainers ...

grumbles
On Tue, Jan 5, 2016 at 5:26 PM Rico Sta. Cruz [email protected]
wrote:

ah, haha, right

—
Reply to this email directly or view it on GitHub
#43 (comment).

[BehindTheMath]

This should be fixed by #59.