-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Pjax as EventEmitter? #53
Comments
Good idea. |
I think this will make testing easier and cleaner, as it will be easier to remove event listeners and avoid issues of event listeners on |
Oddly enough, I ran into this issue tonight. I'm using multiple Once both are used, one stops working (events never fired, switches never fired, etc). Sending in custom Is there a workaround for this? |
Why do you need multiple instances? |
@BehindTheMath I have one instance that loads in urls with specific selectors (main content), and another that's being used with a realtime filter (updates the filter's content, filter results) |
It's a bit hard to picture without seeing it, but Pjax is only meant to be used with links and submitting forms, not for filtering data. |
I'm using pjax to click a link, and selectively fetch the content from the URL - nothing different than what's detailed in the README, etc. I just happen to be using multiple pjax instances :) The issue itself is really hard to reproduce - so I'll table it for now. Just wasn't sure if there was a recommended way of handling the scenario of needing multiple instances. Thanks! |
At the moment, events are emitted via document using native dispatchEvent.
This (I think) causes issues if multiple instances of pjax are used.
Better to have Pjax as a EventEmitter emit its own events. This does increase the size of the library (4-5kb?).
The text was updated successfully, but these errors were encountered: