Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate multiple prop types with config file args overriding command-line args #68

Open
bestchai opened this issue May 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bestchai
Copy link
Member

bestchai commented May 26, 2020

Now that multiple prop types can be input, it's possible that someone inputting a config file and expecting the prop type in the config file to override the command line one may instead mine two prop types. Investigate + fix.

[Issue created by carolemieux: 2015-10-04]
[Last updated on bitbucket: 2015-10-05]

[Comment created by bestchai: 2015-10-05]
I think that the default arg behavior for prop types is to have them be cumulative -- each -f arg adds a new type to mine.

However, in the case that the user may want to override types specified on the command line so far, we can add a new binary arg that changes this default behavior to mine just one prop type -- the last one specified on the command line.

Another issue with cumulative/multi prop type mining are the global semantics of support/confidence thresholds. At the moment there is no way to specify these thresholds per property type.. perhaps a new issue should be created for supporting custom thresholds per prop type.

@bestchai bestchai added the bug Something isn't working label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant