Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show confirmation when navigating away from in-progress upload form #1001

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Show confirmation when navigating away from in-progress upload form #1001

wants to merge 1 commit into from

Conversation

allanlasser
Copy link
Member

Fixes #983

When the upload form isn't empty or is loading, show a confirmation dialog before completing a navigation away.

@netlify Netlify
Copy link

netlify bot commented Jan 10, 2025 •
edited
Loading

✅ Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit a672aac
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/67816558e61d9c0008aa784c
😎 Deploy Preview https://deploy-preview-1001.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 23 (🔴 down 27 from production)
Accessibility: 87 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.84% 7674 / 24098
🔵 Statements 31.84% 7674 / 24098
🔵 Functions 47.74% 339 / 710
🔵 Branches 75.71% 1113 / 1470
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/forms/DocumentUpload.svelte 100% 26.66% 50% 100%
Generated in workflow #552 for commit a672aac by the Vitest Coverage Report Action

@allanlasser allanlasser marked this pull request as ready for review January 10, 2025 18:25
@allanlasser allanlasser requested a review from eyeseast January 10, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyeseast eyeseast Awaiting requested review from eyeseast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible to navigate away from uploads page mid-upload
1 participant
@allanlasser