Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgCompoundRigidSensor should have more tags in its sensor log heading #204

Open
apsabelhaus opened this issue Feb 4, 2017 · 0 comments
Open
Assignees

Comments

@apsabelhaus
Copy link
Member

At the moment, tgCompoundRigidSensor only logs the tag that's the hash for all the rigid models inside its compound rigid body. This does not give much information about which compound rigid is which, and makes it difficult to interpret the log file if there are lots of compounds.

It would be better if it had tags similar to how the cables now have tags: maybe the labels used in a YAML file, for example.

One fix would be for tgCompoundRigidSensor to take the union of all the tags of all the objects in that compound rigid body. That way, in traditional model files, a developer would only have to tag one object inside a compound with e.g. "vertebra1" and that tag would appear in the tgCompoundRigidSensor output.

However, for this to be useful in YAML files, tags for rigid bodies will need to be propagated down the hierarchy of tgModels, which does not currently happen. For example, right now, a tgRod inside a substructure called "t1" will not have "t1" in its tags. It was not too difficult to make any connectors (cables) have tags like this, but to make rigid objects have that tag, many of the functions inside TensegrityModel.cpp will have to be changed to include a std::vectorstd::string argument too, and add that vector of strings as tags for a new tgModel that's created as the YAML file is parsed.

Also, we should check if adding these extra tags will break anyone's code (for example, if anyone has written controllers that assume that only connectors have certain tags.)

@apsabelhaus apsabelhaus self-assigned this Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant