Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Use of Node Normalizer Whole Response #364

Closed
MarkDWilliams opened this issue Mar 2, 2023 · 2 comments
Closed

Investigate Use of Node Normalizer Whole Response #364

MarkDWilliams opened this issue Mar 2, 2023 · 2 comments
Assignees

Comments

@MarkDWilliams
Copy link
Collaborator

Chris B informs me that there is an endpoint in the node normalizer to normalize an entire TRAPI Message (kg, results, etc) as opposed to the piecemeal way we currently have implemented. We should look into using this method as normalizing the entire message is what we're ultimately doing.

@MarkDWilliams MarkDWilliams self-assigned this Mar 2, 2023
@sstemann
Copy link
Contributor

sstemann commented Mar 2, 2023

will address #363 first

@ShervinAbd92
Copy link
Collaborator

taking a look at SRI node normalizer code gave us the idea of incorporating equivalent_identifiers and type fields that normalizer returns into our nodes. As for equivalent_identifiers we will only add the "same_as" attribute only if it doesn't already exists in the attribute list. However, as for type field we are not certain that adding it to the node categories field is a good idea as it includes most of connecting entities to our queried entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants