-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARS queries a subset of KPs? #501
Comments
Multiomics KPs has been digested through ara-bte, do we need to pull them separately? If so, there are the some of the endpoints: #Multiomics wellness #Multiomics clinical trial |
Hi @edeutsch which subset of kps are we not hitting? the ones that return 598 error are mainly due to getting timedout after 5 min. |
Spoke is one, see NCATSTranslator/Feedback#523 In total there are 32 TRAPI KPs listed here: https://arax.ci.transltr.io/?smartapi=1 If the 598 means that these services are timing out after 5 minutes, that would imply that 6 out of 8 KPs the ARS queries are routinely (always?) timing out after 5 minutes. That would seem to be bad, but is never discussed. |
looking at the ARS structure i see that we only have 8 of them registered but we should be able to add them, unless there is a reason we haven't done so far. @MarkDWilliams what do you think about that? |
On the one hand, I'm guessing the KP responses are not used for results returned to the UI, so there's no need for the ARS to be querying KPs at all |
I think in production at least, I would lean towards deregistering all the KPs as they aren't really necessary for anything beyond debugging. In the lower environments, I am more split. There is some value to having them for testing, but really only for testing. So, maybe they should only be called if specified? Not sure the best way to implement that switch just yet. |
My two cents are that the ARS shouldn't be the one "testing" kps, but that it should be a separate more dedicated test. |
I would also vote that the normal mode of ARS operation would only be to query active ARAs. If there is a separate special mode to query all agents including all KPs, that would be interesting and useful, but I suggest not routine operation. |
Something I've often wondered: the ARS seems to query some KPs, but only a subset. Is there some intention to the subset of KPs that are queried? Do we want ARS to query them all? Do we want ARS to query none? Or is the current subset still good?
Many seem to always return errors? It seems to me that MolePro is usually the only one that usually returns a non-error.
e.g.:
![image](https://private-user-images.githubusercontent.com/12707718/266700468-754512f1-26a3-4b09-844f-03debb7c2918.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNjMwNjMsIm5iZiI6MTczOTM2Mjc2MywicGF0aCI6Ii8xMjcwNzcxOC8yNjY3MDA0NjgtNzU0NTEyZjEtMjZhMy00YjA5LTg0NGYtMDNkZWJiN2MyOTE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDEyMTkyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNlOTk1ZTgwNTI1M2MwODEzOGFmYzMxMTQ0NWE0YTRiNmY0ZGRiMTk1Y2Q2ZGVjNGY3ZDU4MjdkMmZhZjg4NmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.y6jzKpPAfbCm4xz1rAWrnEsH8-FCPS9_b9T3g1W4Rcw)
https://arax.ci.transltr.io/?r=0bf293be-7e4c-4057-ab50-7f34670e5b61
The text was updated successfully, but these errors were encountered: