Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_compliance_of_trapi_response() only works with Message not Response #41

Closed
edeutsch opened this issue Oct 20, 2022 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@edeutsch
Copy link

Moving from reasoner-validator 2.2.14 to 3.1.0 with some issues.

Version 3.1 seems to work with this:

from reasoner_validator import TRAPIResponseValidator
    validator = TRAPIResponseValidator(trapi_version=trapi_version, biolink_version=biolink_version, sources=None, strict_validation=True)
    validator.check_compliance_of_trapi_response(message=envelope['message'])
    validation_result = validator.get_messages()

And seems to work pretty well. The most startling thing is that even though the class and main method are named as if they are designed to validate a TRAPI Response object, the check_compliance_of_trapi_response() method only seems to work when passed a TRAPI Message object (child of Response). Does not work when passed a Response object. I think it should!

@RichardBruskiewich
Copy link
Collaborator

Tagged issue #48 as a duplicate of this issue...I'll take a closer look at this after I get the fresh iteration of the SRI Testing harness data and web dashboard out by early next week.

@RichardBruskiewich
Copy link
Collaborator

This issue substantially resolved by commit 0e5ed3a.

There are some additional TRAPI workflow validation measure which could be taken but we defer these to another day (and issue: #57) but consider this issue otherwise resolved (for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants