Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetSpike Tests #58

Open
sophiafarrell opened this issue Mar 3, 2021 · 1 comment
Open

Fix GetSpike Tests #58

sophiafarrell opened this issue Mar 3, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@sophiafarrell
Copy link
Contributor

TravisCI was having a hard time occasionally with the GetSpike test. Probably a NEST issue, or we are feeding incorrect parameters in. Here's where it's defined:

nestpy/src/nestpy/NEST.cpp

Lines 1518 to 1520 in f68b74f

vector<double> NESTcalc::GetSpike(int Nph, double dx, double dy, double dz,
double driftSpeed, double dS_mid,
const vector<double>& oldScint) {

And here is our test for it:

# def test_nestcalc_get_spike(self):
# # This is stalling some builds. Need to improe the test.
# self.nestcalc.GetSpike(10, 10., 20., 30., 10., 10., [0, 1, 2])

I have found testing this locally also can replicate the issue; code just freezes up. It's more important to get nestpy patch out than get this particular rarely-used function working but we should definitely fix before next patch.

@sophiafarrell sophiafarrell added the bug Something isn't working label Mar 3, 2021
@sophiafarrell
Copy link
Contributor Author

@tunnell FYI. No TODO yet, but just aware of this tiny enhancement for our tests we'll need to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant