Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Authenticated iframe with JWT #49

Open
jbonor opened this issue Jan 20, 2025 · 3 comments · May be fixed by #51
Open

[Feature]: Authenticated iframe with JWT #49

jbonor opened this issue Jan 20, 2025 · 3 comments · May be fixed by #51
Labels
feature New feature or request wontfix This will not be worked on

Comments

@jbonor
Copy link

jbonor commented Jan 20, 2025

Describe the feature request

Please take a look at Mikesch-mp/icingaweb2-module-grafana/pull/326 and consider merging it, it's very useful

Thanks.
@jbonor jbonor added the feature New feature or request label Jan 20, 2025
@martialblog
Copy link
Member

Hi, thanks for the hint. We have had our eyes on that, however the implementation in the PR is not optimal thus I didn't include it.

This fork was created to provide bug fixes and maintenance, so we currently don't plan to include any major features.

@martialblog martialblog added the wontfix This will not be worked on label Jan 20, 2025
@jbonor
Copy link
Author

jbonor commented Jan 20, 2025

Hi, thanks for the hint. We have had our eyes on that, however the implementation in the PR is not optimal thus I didn't include it.

This fork was created to provide bug fixes and maintenance, so we currently don't plan to include any major features.

Do you mind if I ask what's not optimal and if it's fixable? I may have some time to spent on it

@martialblog
Copy link
Member

I mainly did not include it because of the entire Firebase\JWT lib, which introduces a big external dependency.

@jbonor jbonor linked a pull request Jan 21, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for authenticated iframe (with JWT) jbonor/icingaweb2-module-grafana
2 participants
@jbonor @martialblog