Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basis with c & cbar #1627

Closed
4 of 5 tasks
scarlehoff opened this issue Nov 11, 2022 · 12 comments
Closed
4 of 5 tasks

Add a basis with c & cbar #1627

scarlehoff opened this issue Nov 11, 2022 · 12 comments
Assignees

Comments

@scarlehoff
Copy link
Member

scarlehoff commented Nov 11, 2022

Which also requires ensuring that the rotation to the fktable basis and sum rules work.

  • Add the c-cbar basis
  • FKTable rotation (see Add a basis with c & cbar #1627 (comment))
  • Sum rules
  • Check that old FK Tables are not optimizing out the ccbar asymmetry
  • Check that pineappl FK Tables are not optimizing out the ccbar asymmetry

@felixhekhorn I added you to this issue just because of the last point ofc, let us now and if it is we just do a theory 4XY with the asymmetry.

Although I wonder whether the fktables in theory 200 would allow for it (I'll have a look at that)

@tgiani
Copy link
Contributor

tgiani commented Nov 11, 2022

thank you @scarlehoff I m happy to work on this

@tgiani
Copy link
Contributor

tgiani commented Nov 11, 2022

in the FK tables I think there is already V15, which now is taken equal to V, no?

@felixhekhorn
Copy link
Contributor

  • Check that old FK Tables are not optimizing out the ccbar asymmetry

@scarlehoff
Copy link
Member Author

scarlehoff commented Nov 11, 2022

in the FK tables I think there is already V15, which now is taken equal to V, no?

Yes. The value is allowed. I'm wondering whether in Th 200 they are optimized by making V = V + V15.

@tgiani
Copy link
Contributor

tgiani commented Nov 11, 2022

from the n3fit point of view, in order to add a parameterization for c-cbar, is it enough to use nodes_per_layer: [25, 20, 9] in the runcard and then just change the FK table rotation to account for V15?

@scarlehoff
Copy link
Member Author

I've removed my previous msg. No, unfortunately in pdfbases.py we implicitly assume that the maximum number of flavours that are going to be fitted is 8.

So we need to scratch this function:

def fitbasis_to_NN31IC(flav_info, fitbasis):

And then address this TODO from 3 years ago

# TODO: Generate a rotation matrix in the input and just do tf.tensordot in call
which didn't matter until now.

@Radonirinaunimi
Copy link
Member

And then address this TODO from 3 years ago

# TODO: Generate a rotation matrix in the input and just do tf.tensordot in call

which didn't matter until now.

Oh, if you remember @scarlehoff we discussed about this a bit at some point in the context of nuclear PDFs (where only 6 flavours are active) and I sort of recall I had a go on this.

@tgiani
Copy link
Contributor

tgiani commented Nov 11, 2022

right yes I remember this function. But it s ok, just need to change it with the new basis definition before doing the rotation to the FK basis I would say

@scarlehoff
Copy link
Member Author

Yes. It shouldn't be a problem. It's just not as ready as I thought :P

Oh, if you remember @scarlehoff we discussed about this a bit at some point in the context of nuclear PDFs (where only 6 flavours are active) and I sort of recall I had a go on this.

Right. But in principle this is the opposite scenario. Actually in this case the "relevant" part is in the vp side so the two changes should not be incompatible I'd say.

@tgiani
Copy link
Contributor

tgiani commented Nov 11, 2022

I ll have a go and open a PR to iterate with you and @Radonirinaunimi

@scarlehoff
Copy link
Member Author

In the meantime, I had a look at theory 200 and there is V15 in the fktables so we can use th 200 for now.

@scarlehoff
Copy link
Member Author

Closed with #1629

For the fktables with ccbar, that's pineko's job NNPDF/pineko#64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants