Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply the mapping from dataset_names.yaml also to loaded theory covmats #2174

Closed
RoyStegeman opened this issue Oct 16, 2024 · 0 comments · Fixed by #2203
Closed

Apply the mapping from dataset_names.yaml also to loaded theory covmats #2174

RoyStegeman opened this issue Oct 16, 2024 · 0 comments · Fixed by #2203

Comments

@RoyStegeman
Copy link
Member

(I believe) vp-comparefits relies on covmats having the same labels between fits and thus comparing two theory covmat fits, one with the old naming convention, and one with the new, is not possible at the moment.

See also #2167 (comment) and discussion in that PR.
@RoyStegeman RoyStegeman linked a pull request Nov 8, 2024 that will close this issue
Old commondata thcovamat compatibility #2203
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Old commondata thcovamat compatibility NNPDF/nnpdf
1 participant
@RoyStegeman