-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve theory handling #1
Comments
I'll start working on these right after NNPDF/pinecards#108 will be more or less settled. |
A couple of comments about practical steps
This one it's fairly easy on its own, but most likely we'll need immediately a theory extension, because not all the parameters used are currently available in theory database (e.g. widths are not)
This is really easy as it is, but there is the further complication that adding just the theory ID we'll really become dependent on useless evolution parameters. Ideally I would like to depend only on parameters used (so one by one, not even on a subset as a block).
The reason for this is that currently the runcard can be specified as a name or as a path, while for theories you always have to specify the path. I like the more flexible option of runcards. |
One problem that I've just noticed is that for Madgraph5_aMC@NLO runs the parameter values aren't extracted from the theory but rather from variables.json. This leads to a potential mismatch between DIS and collider datasets and is dangerous for this exercise: NNPDF/pinecards#134. |
Yes, this is well known: it is exactly the content of this issue. If you remember, before they were hard-coded in the I was waiting for a consistent theory scheme upgrade, but right now a further intermediate step came to mind: we can overwrite This is something we don't want to do for theory 400, since it would be another source of discrepancies wrt theory 200 (and 400 is a transition theory anyhow): until now APPLgrids parameters were not always consistent with the specified theory (think about grids we received from someone else). |
Starting with the Python implementation of the runner we have to specify a theory whenever we want to generate a grid, for instance
I think we should reflect this in the filename of the generated grid, so in this instance we should generate
TEST_RUN_SH_T200.pineappl.lz4
, which tells us the grid was generated with theory 200.Furthermore, we need to discuss
Further steps breakout:
The text was updated successfully, but these errors were encountered: