-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix datasets with jets #13
Comments
I've not a perfect understanding, but to me seems like option 1) is sufficiently more complicated than 2) (do we need to run an extra step in the runner? do we need to embed the fortran/python code?). Option 2) looks like something I can do with |
I like option 2 better than 1, because it's faster as you said, but it requires some non-trivial adjustments. We need to essentially sort our custom cuts according to jet cut/non-jet cuts, and then write them into different functions in |
We can simply split them in two folders (the natural way to create scopes on filesystem). We can split by hand, they are not that many (and we should check we are choosing them correctly). |
@alecandido I'm a bit unhappy about the fact that Madgraph5 changed this; a possible problem that I see is that there are cuts that concern jets and leptons at the same time, meaning that we can't separate them, and I wonder if it isn't a better choice to rewrite the cutting routine slightly so that we don't have to change our cuts. |
I'm not an expert of |
@cschwan I'm not sure if this is 100% related to the MadGraph pinecards, or I should transfer to pinefarm. But maybe you know. |
This concerns the code that patches/runs Madgraph, so I suppose it should go to pinefarm. |
This concerns the implementation of patches/cut in Madgraph, so it should be a pinefarm issue. |
@ramonpeter this is the issue I was thinking about when saying, that the interface is broken for some Madgraph version |
If I can see correctly, the last version with which it was running properly was v3.3.1, is this correct? |
According to my first comment it seems v3.3.1 was a version where it broke, so I guess v3.2 and v3.3.0 are potential candidates where our patches still work. |
In Madgraph5_aMC@NLO v3.3.1 the cutting routine was changed, so that
pjet
isn't calculated in the place where we use it anymore. We either have to 1) run the jet algorithm ourselves or 2) move jet-related custom cuts frompasscuts_user
topasscuts_jets
incuts.f
.The text was updated successfully, but these errors were encountered: