Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new DAMP convention #141

Closed
giacomomagni opened this issue Dec 3, 2023 · 1 comment · Fixed by #142
Closed

Fix new DAMP convention #141

giacomomagni opened this issue Dec 3, 2023 · 1 comment · Fixed by #142
Labels
bug Something isn't working

Comments

@giacomomagni
Copy link
Contributor

In #140, we have changed the convention for DAMP: 0, but this line has not been fixed accordingly.

is_damped = damp != 0

It should be replaced with:

 is_damped = damp != -1
@giacomomagni giacomomagni added the bug Something isn't working label Dec 3, 2023
@alecandido
Copy link
Member

Just to mention it: in a sense, a common part would be to put

 is_damped = damp > 0

but I believe that being more specific would be better (in case you made an error somewhere, there are more chances that you can predict the outcome).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants