You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi all,
While working on a PR for arbitrary region selection and testing my code, I came across the following question, which I think merits discussion.
Currently, when we pair with point data, we save (sensibly, IMHO) only those points that are paired. This, however, has the following disadvantage: an.read_analysis() is not sufficient for all our plots. I.e., plots like the spatial_overlay() require reading also the model.
This is not necessarily a problem, it somehow makes sense that "paired_data" includes only those data that are effectively paired.
However, it leads to a difference between pairing with gridded data (i.e., satellite or, maybe in the future, pairing two models), where the paired.obj are self contained and we can do all plot just reading that in, and point/mobile data, where that is not the case, especially for maps. Right now, the fact that the model needs to be read again is not obvious in the docs nor in the examples.
I can think of 2 potential solutions:
Just updating the docs to make that difference clear and specify that, for some of the plots (spatial overlay being the only example right now) the user still needs to run an.read_model(). I would also add a clear error message to make_spatialoverlay if the user did not read the model after running an.read_analysis(), and probably deal with it by skipping it. It does not make sense that they would need to re-run everything if just those plots failed. I'm leaning towards this, it just seems like a better, more straightforward solution.
Changing the paired data to include all of it. This has quite some disadvantages, since it would mean having data full of NaN for the observations. It is also not clear how the resample would work for mobile/aircraft. It has the main advantage that the data saved with an.save_analysis() would be self contained. @rschwant , @zmoon , @lkemmons what do you think?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi all,
While working on a PR for arbitrary region selection and testing my code, I came across the following question, which I think merits discussion.
Currently, when we pair with point data, we save (sensibly, IMHO) only those points that are paired. This, however, has the following disadvantage: an.read_analysis() is not sufficient for all our plots. I.e., plots like the spatial_overlay() require reading also the model.
This is not necessarily a problem, it somehow makes sense that "paired_data" includes only those data that are effectively paired.
However, it leads to a difference between pairing with gridded data (i.e., satellite or, maybe in the future, pairing two models), where the paired.obj are self contained and we can do all plot just reading that in, and point/mobile data, where that is not the case, especially for maps. Right now, the fact that the model needs to be read again is not obvious in the docs nor in the examples.
I can think of 2 potential solutions:
@rschwant , @zmoon , @lkemmons what do you think?
Beta Was this translation helpful? Give feedback.
All reactions