Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point sum errors with longitude normalization in MONET #314

Open
rschwant opened this issue Nov 20, 2024 · 1 comment
Open

Floating point sum errors with longitude normalization in MONET #314

rschwant opened this issue Nov 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rschwant
Copy link
Collaborator

There are some small floating point sum errors with the longitude normalization in MONET that impact the pairing step in MELODIES MONET namely for the vertical interpolation we need to pick the right value based on the exact values for latitude, longitude, and pressure_obs. These longitudes are not the same in Python speak: 120.711744 and 120.71174400000001. The result is for some datasets (e.g., first noticed with the ASIA-AQ data) there are a lot of NaNed values when doing the pairing step.

We will document how we are fixing this here in case it comes up again for other datasets.

@rschwant rschwant added the bug Something isn't working label Nov 20, 2024
@rschwant
Copy link
Collaborator Author

Zach is working on a fix in MONET here for this: noaa-oar-arl/monet#160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant