From 244693c68d47087bf530cc2d117ad2989e5193d2 Mon Sep 17 00:00:00 2001
From: Jiarui Dong <Jiarui.Dong@noaa.gov>
Date: Thu, 14 Nov 2024 17:45:49 -0500
Subject: [PATCH] Address reviewer's comments.

---
 parm/snow/obs/config/sfcsno_snow.yaml.j2                       | 2 +-
 .../ioda/bufr2ioda/bufr2ioda_sfcsno_bufr_encoder.py            | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
 rename parm/snow/ioda_bufr_python_encoder.py => ush/ioda/bufr2ioda/bufr2ioda_sfcsno_bufr_encoder.py (92%)

diff --git a/parm/snow/obs/config/sfcsno_snow.yaml.j2 b/parm/snow/obs/config/sfcsno_snow.yaml.j2
index 9f2d9cd24..d17d3e9b0 100644
--- a/parm/snow/obs/config/sfcsno_snow.yaml.j2
+++ b/parm/snow/obs/config/sfcsno_snow.yaml.j2
@@ -6,7 +6,7 @@
     obsdatain:
       engine:
         type: script
-        script file: "{{ PARMgfs }}/gdas/snow/ioda_bufr_python_encoder.py"
+        script file: "{{ USHgfs }}/bufr2ioda_sfcsno_bufr_encoder.py"
         args:
           input_path: '{{ DATA }}/obs/{{ OPREFIX }}sfcsno.tm00.bufr_d'
         obsfile: '{{ DATA }}/obs/{{ OPREFIX }}sfcsno.tm00.bufr_d'
diff --git a/parm/snow/ioda_bufr_python_encoder.py b/ush/ioda/bufr2ioda/bufr2ioda_sfcsno_bufr_encoder.py
similarity index 92%
rename from parm/snow/ioda_bufr_python_encoder.py
rename to ush/ioda/bufr2ioda/bufr2ioda_sfcsno_bufr_encoder.py
index f8f9c0f58..9fdc59538 100644
--- a/parm/snow/ioda_bufr_python_encoder.py
+++ b/ush/ioda/bufr2ioda/bufr2ioda_sfcsno_bufr_encoder.py
@@ -37,7 +37,6 @@ def create_obs_group(input_path):
 
     masked_container = mask_container(container, (~snod.mask))
 
-    encoder = Encoder(YAML_PATH)
-    data = next(iter(encoder.encode(masked_container).values()))
+    data = next(iter(Encoder(YAML_PATH).encode(masked_container).values()))
 
     return data