Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paths for UFS-DA var and ens ctests #455

Closed
RussTreadon-NOAA opened this issue May 1, 2023 · 2 comments · Fixed by #456
Closed

Update paths for UFS-DA var and ens ctests #455

RussTreadon-NOAA opened this issue May 1, 2023 · 2 comments · Fixed by #456
Assignees

Comments

@RussTreadon-NOAA
Copy link
Contributor

The merger of g-w PRs #1537 and #1538 break GDASApp ctests

  Test #1463: test_gdasapp_atm_jjob_var_init
  Test #1464: test_gdasapp_atm_jjob_var_run
  Test #1465: test_gdasapp_atm_jjob_var_final
  Test #1466: test_gdasapp_atm_jjob_ens_init
  Test #1467: test_gdasapp_atm_jjob_ens_run
  Test #1468: test_gdasapp_atm_jjob_ens_final

The cited g-w PRs update UFS-DA ATM var and ens j-jobs and scripts to the new GFS COM directory structure (see g-w PR #1421). The var and ens init jobs fail because they can no longer find the required input. The run and final jobs fail because the required input files are missing.

The fix is twofold:

  1. The 20210323 enkfgdas and gdas directories in GDASAPP_TESTDATA=/scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/data need to be updated to the new GFS COM directory structure
  2. The ctest var and ens init driver scripts need to reference the new GFS COM directory structure

This issue is opened to document this problem and its resolution.

@RussTreadon-NOAA
Copy link
Contributor Author

Work for this issue will be done in RussTreadon-NOAA:feature/gfscom.

@RussTreadon-NOAA
Copy link
Contributor Author

Four files updated in test/atm/global-workflow at 1313ffd:

  1. config.atmanl - remove R2D2 and FV3JEDI_FIX since no longer used
  2. config.base.emc.dyn - update to be consistent with g-w config.base.emc.dyn
  3. jjob_ens_init.sh - update UFS-DA ATM ensemble initialize job to use new GFS COM directory structure
  4. jjob_var_init.sh - update UFS-DA ATM variational initialize job to use new GFS COM directory structure

The above changes are not sufficient for the six test_gdasapp tests to pass. The location of input files in $GDASAPP_TESTDATA needs to updated to the new GFS COM directory structure. This rearrangement of directories has been done in /scratch1/NCEPDEV/stmp2/Russ.Treadon/CI/GDASApp/data/lowres/

Directories enkfgdas.20210323 and gdas.20210323 in /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/data should be removed and refreshed with the same named directories from /scratch1/NCEPDEV/stmp2/Russ.Treadon/CI/GDASApp/data/lowres.

For the purpose of testing in this issue GDASAPP_TESTDATA was reset to point at /scratch1/NCEPDEV/stmp2/Russ.Treadon/CI/GDASApp/data. With this change and the above modified four files all six ctests pass on Hera.

(gdasapp) Hera(hfe08):/scratch1/NCEPDEV/da/Russ.Treadon/git/global-workflow/work/sorc/gdas.cd/build$ ctest -R test_gdasapp_atm_jjob
Test project /scratch1/NCEPDEV/da/Russ.Treadon/git/global-workflow/work/sorc/gdas.cd/build
    Start 1463: test_gdasapp_atm_jjob_var_init
1/6 Test #1463: test_gdasapp_atm_jjob_var_init ....   Passed   42.89 sec
    Start 1464: test_gdasapp_atm_jjob_var_run
2/6 Test #1464: test_gdasapp_atm_jjob_var_run .....   Passed   74.09 sec
    Start 1465: test_gdasapp_atm_jjob_var_final
3/6 Test #1465: test_gdasapp_atm_jjob_var_final ...   Passed   42.15 sec
    Start 1466: test_gdasapp_atm_jjob_ens_init
4/6 Test #1466: test_gdasapp_atm_jjob_ens_init ....   Passed   44.62 sec
    Start 1467: test_gdasapp_atm_jjob_ens_run
5/6 Test #1467: test_gdasapp_atm_jjob_ens_run .....   Passed  170.71 sec
    Start 1468: test_gdasapp_atm_jjob_ens_final
6/6 Test #1468: test_gdasapp_atm_jjob_ens_final ...   Passed   43.00 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 417.93 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant