Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calc_analysis read fix for C1152 #56

Closed
CatherineThomas-NOAA opened this issue Dec 16, 2024 · 2 comments · Fixed by #57 or #59
Closed

Calc_analysis read fix for C1152 #56

CatherineThomas-NOAA opened this issue Dec 16, 2024 · 2 comments · Fixed by #57 or #59
Assignees
@RussTreadon-NOAA @CatherineThomas-NOAA

Comments

@CatherineThomas-NOAA
Copy link
Contributor

When running calc_analysis for C1152, the job fails in the read of the delp increment:

call read_vardata(incncfile, 'delp_inc', work3d_inc)

This read has a different format than the other 3d increment reads:

call read_vardata(incncfile, trim(incvar)//"_inc", work3d_inc_gsi, nslice=k, slicedim=3)

Adding nslice=k, slicedim=3 to the delp_inc read along with a do loop over k allows the job to succeed.

The fix will be in bugfix/delp.
CatherineThomas-NOAA added a commit to CatherineThomas-NOAA/GSI-utils that referenced this issue Dec 16, 2024
@CatherineThomas-NOAA
Calc_analysis fix for delp increment read to allow C1152 cycling (NOA…
99ead60 
…A-EMC#56)
@RussTreadon-NOAA RussTreadon-NOAA linked a pull request Dec 17, 2024 that will close this issue
Calc_analysis fix for delp increment read to allow C1152 cycling (#56) #57
Merged
CoryMartin-NOAA pushed a commit that referenced this issue Dec 17, 2024
@CatherineThomas-NOAA
Calc_analysis fix for delp increment read to allow C1152 cycling (#56) (
7aed28e 
#57)
CoryMartin-NOAA added a commit that referenced this issue Dec 17, 2024
@CoryMartin-NOAA
Revert "Calc_analysis fix for delp increment read to allow C1152 cycl…
0f5e4e8 
…ing (#56…"

This reverts commit 7aed28e.
CoryMartin-NOAA added a commit that referenced this issue Dec 17, 2024
@CoryMartin-NOAA
Revert "Calc_analysis fix for delp increment read to allow C1152 cycl…
b5c3bb0 
…ing (#56…" (#58)

This reverts commit 7aed28e.
@CoryMartin-NOAA
Copy link
Contributor

We have reverted the hastily merged PR and have a better solution that needs a PR.

@RussTreadon-NOAA
Copy link
Contributor

Branch bugfix/calcanal created for this issue

RussTreadon-NOAA added a commit that referenced this issue Dec 18, 2024
@RussTreadon-NOAA
replace work3d_inc with work2d_inc in add_psfc_increment (#56)
3dc7a7f
@RussTreadon-NOAA RussTreadon-NOAA mentioned this issue Dec 18, 2024
Merged
CoryMartin-NOAA pushed a commit that referenced this issue Jan 3, 2025
@RussTreadon-NOAA
replace work3d_inc with work2d_inc in add_psfc_increment (#56) (#59)
e6ce414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RussTreadon-NOAA RussTreadon-NOAA

@CatherineThomas-NOAA CatherineThomas-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@CoryMartin-NOAA @RussTreadon-NOAA @CatherineThomas-NOAA