NDS: Array size mismatch?

[ukmo-ccbunney]

I think there is a discrepancy between the size of the NDS variable (used to hold file unit numbers) defined in w3odatmd here as size 15:

WW3/model/src/w3odatmd.F90

Line 439 in eff6686

TBPI0(2), TBPIN(2), NDS(15), OFILES(7)

and elsewhere as size 13, e.g.

WW3/model/src/ww3_shel.F90

Line 332 in eff6686

INTEGER :: NDSF(-7:9), NDS(13), NTRACE(2), NDT(7:9), &

This is resulting in an array bounds mismatch in w3initmd:

WW3/model/src/w3initmd.F90

Line 693 in eff6686

NDS = MDS

MDS is of size 13 in this case and NDS is size 15.

[ukmo-ccbunney]

I think this bug was introduced in #1089
W3ODATMD was updated to increase the size of NDS to 15, but MDS/NDS is still sized as 13 in the W3INIT parameter list and in ww3_shel.f90

[MatthewMasarik-NOAA]

Very nice catch, @ukmo-ccbunney. I see you self-assigned, may I ask if you're also working on a fix? I had many unexpected non-b4b's with matrix.comp for the next PR (#1083), I'm hoping resolving this may help with that.

[ukmo-ccbunney]

@MatthewMasarik-NOAA Yes - I'm happy to put a fix together for this. Watch this space :)

[MatthewMasarik-NOAA]

Awesome, thanks so much @ukmo-ccbunney !

[ukmo-ccbunney]

Also, I think the ASCII output unit numbers are not actually set when running ww3_shel, i.e. NDS(14) and NDS(15) are not defined as far as I can tell.