Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector Halo Exchange issue(s) #81

Open
4 tasks
FlorianDeconinck opened this issue Oct 11, 2024 · 1 comment
Open
4 tasks

Vector Halo Exchange issue(s) #81

FlorianDeconinck opened this issue Oct 11, 2024 · 1 comment

Comments

@FlorianDeconinck
Copy link
Collaborator

A list of issue has crept up around the vector halo exchange. The extent of the problems are still to be determined but we are seeing:

  • a transparency issue: 1x1 and 3x3 layout seems to not give the same results for vector halo update on ndsl.
  • a difference with Fortran: likewise, when comparing 3x3 layout between ndsl and fms differences in data selection shows (ranks seems correct).
  • confusion about the C-grid/D-grid position of U and V in the acoustics portion of pyFV3: the last 2 halo exchanges on the n_split need to be clarified versus the reference Fortran.

Overall, the FMS and original Fortran uses the "staircase" projection of the cube-sphere, while ndsl uses the "T" projection. We need to go back and figure out exactly if this change has been carried through the code properly and document the differences to the original model.

DOD:

  • Use FMS to generate a failing unit test for ndsl on 3x3 layout for vector exchange
  • Fix the vector halo exchange or move roll the fix into the larger non-square layout work
  • Document cube-sphere representation for ndsl (vs FMS)
  • Investigate the acoustics halo exchange and make sure they are well named and perform the same operation as the reference Fortran
@bensonr
Copy link

bensonr commented Oct 11, 2024

I'd like to add as part of the documenting of the cubed-sphere representation we should agree on the nomenclature for north, south, east, and west based on the origin of the domain, i.e. which "corner" is (0,0) located at for each tile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants