milestone 1.5 code review

[randytpierce]

This is a placeholder issue for the purpose of collecting code review related issues, documents etc.

[randytpierce]

Pleaser refer to the document https://docs.google.com/document/d/1__Qz5f9psBJi5Vlw_J2rKTAXlMUyxvJ77zJ890bHmFk/edit?usp=sharing

[ian-noaa]

Is there anything more that needs to be done here or should we close this?

I recall that we wanted to make issues out of the parking lot. Below is what we had, with potential related issues linked.

• Data fetch vs query on HPC
• Need to understand time to live for documents, right now we don’t have it implemented
• Need to create couchbase container and a mechanism for loading test data into it
• convert tests to all be pytest
• find out if "fcstLens": "0,1,3,6,9,12,15,18,21,24,27,30,33,36" is being adhered to in gribBuilder ingest doc.
• Get CI set up (Set Up GitHub Actions #73, Set up Python tooling #40)
• How to manage development / deployment on HPC (Python 3 miniconda environment on Jet #29)

[randytpierce]

All of the above issues have been created in the VXingest project so I am closing this issue.

[randytpierce]

I created all of the issues referenced in the issue and closed the issue. I am still a little confused about one thing. Do all issues still need to be assigned to someone? I assigned all these to myself just in case, but I certainly won't be working them all at once. randy

…

On Tue, May 17, 2022 at 9:34 PM Ian McGinnis ***@***.***> wrote: Is there anything more that needs to be done here or should we close this? I recall that we wanted to make issues out of the parking lot. Below is what we had, with potential related issues linked. - Data fetch vs query on HPC - Need to understand time to live for documents, right now we don’t have it implemented - Need to create couchbase container and a mechanism for loading test data into it - convert tests to all be pytest - find out if "fcstLens": "0,1,3,6,9,12,15,18,21,24,27,30,33,36" is being adhered to in gribBuilder ingest doc. - Get CI set up (#73 <#73>, #40 <#40>) - How to manage development / deployment on HPC (#29 <#29>) — Reply to this email directly, view it on GitHub <#117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGDVQPR2ZNEETRKETGNRML3VKRQKNANCNFSM5UP2TR2Q> . You are receiving this because you were assigned.Message ID: ***@***.***>

-- Randy Pierce

[ian-noaa]

I don't think all the issues need to be assigned - the unassigned ones will show up on our project board and we can prioritize & assign them as needed.

[randytpierce]

Ok, I'll un-assign those issues, then. randy

…

On Mon, May 23, 2022 at 1:42 PM Ian McGinnis ***@***.***> wrote: I don't think all the issues need to be assigned - the unassigned ones will show up on our project board and we can prioritize & assign them as needed. — Reply to this email directly, view it on GitHub <#117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGDVQPQE3JQ6ZMEVYU2OQJTVLPNQLANCNFSM5UP2TR2Q> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

-- Randy Pierce

[randytpierce]

I can close that issue and open issues for these. randy

…

On Tue, May 17, 2022 at 9:34 PM Ian McGinnis ***@***.***> wrote: Is there anything more that needs to be done here or should we close this? I recall that we wanted to make issues out of the parking lot. Below is what we had, with potential related issues linked. - Data fetch vs query on HPC - Need to understand time to live for documents, right now we don’t have it implemented - Need to create couchbase container and a mechanism for loading test data into it - convert tests to all be pytest - find out if "fcstLens": "0,1,3,6,9,12,15,18,21,24,27,30,33,36" is being adhered to in gribBuilder ingest doc. - Get CI set up (#73 <#73>, #40 <#40>) - How to manage development / deployment on HPC (#29 <#29>) — Reply to this email directly, view it on GitHub <#117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGDVQPR2ZNEETRKETGNRML3VKRQKNANCNFSM5UP2TR2Q> . You are receiving this because you were assigned.Message ID: ***@***.***>

-- Randy Pierce