Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old code #279

Closed
ian-noaa opened this issue Dec 20, 2023 · 0 comments · Fixed by #291
Closed

Cleanup old code #279

ian-noaa opened this issue Dec 20, 2023 · 0 comments · Fixed by #291
Assignees
Labels
task Tasks break a project down into discrete steps

Comments

@ian-noaa
Copy link
Contributor

We have some unused code that can be removed now that we've switched ingest to be fully Python.

We're no longer using run-ingest.sh so it should be removed:

  • scripts/VXingest_utilities/run-ingest.sh

While I'm at it, I'm curious if the below files can be removed. I've moved everything explicitly used by the test suite to a testdata directory so these files aren't being called by any code at the moment. I believe the *.n1ql files are safe to remove. The *.yaml files may be examples of data documents though. I also noticed a number of NetCDF files in tests/vxingest/netcdf_to_cb that I'm assuming are out of date and can be cleaned up.

  • tests/vxingest/builder_common/*.n1ql
  • tests/vxingest/ctc_to_cb/*.yaml
  • tests/vxingest/grib2_to_cb/*{.yaml,.xml}
  • tests/vxingest/netcdf_to_cb/{2021*,*.yaml}
  • tests/vxingest/partial_sums_to_cb/*{.n1ql,.yaml}
@ian-noaa ian-noaa added the task Tasks break a project down into discrete steps label Dec 20, 2023
@ian-noaa ian-noaa self-assigned this Dec 20, 2023
@ian-noaa ian-noaa linked a pull request Jan 4, 2024 that will close this issue
ian-noaa added a commit that referenced this issue Jan 8, 2024
Remove unused and out-of-date scripts & files. 

Closes #279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Tasks break a project down into discrete steps
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant