You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@danielballan and I noticed that GitHub doesn't recognize or label most Bluesky projects as having a BSD 3-Clause license, even though they ship with what we consider a BSD 3-Clause license.
This means they don't get a prominent license tag that identifies the license at the top of the project landing page:
And they also don't get a header providing a quick overview of license features when you view the license file:
Note that this project is correctly recognized. Ophyd, for example, is not.
The reason for this are differences in the LICENSE file, deviating from what GitHub recognizes as a standard BSD 3-Clause license. We think this is worth fixing, as there is both legal and social value in using an established and recognizable license with minimal deviations.
Reference for what GitHub recognizes as standard: BSD 3-Clause
The current LICENSE in this repo matches this exactly, changing only the [year] and replacing [fullname] with "Brookhaven National Laboratory".
The current LICENSE in many other NSLS-II and Bluesky repos has the following differences:
Missing explicit BSD 3-Clause License declaration on line 1
Names Brookhaven Science Associates as copyright holder in addition to Brookhaven National Laboratory
Has All rights reserved. on same line as copyright, instead of its own line below it
Uses bullet points instead of numbered list of clauses
Modified Clause 3 to again explicitly name Brookhaven Science Associates, Brookhaven National Laboratory as copyright holder, replacing the default reference: the copyright holder
Points 1, 3 and 4 should be straightforward fixes.
Points 2 and 5 require attention.
Once we have answers to the above, the next steps would be:
Update LICENSE in this repo to comply with requirements
Ensure updated LICENSE is still recognized by GitHub, fix if not
Update LICENSEs in other repos to match this one
The text was updated successfully, but these errors were encountered:
Should the copyright line name Brookhaven National Laboratory, or Brookhaven Science Associates, or either, or both?
Is modifying Clause 3 really necessary? Or is the default reference to the copyright holder sufficient?
Leaving Clause 3 unmodified would be ideal, since that is compliant with the standard license format, already references the copyright holder, and is the biggest factor in GitHub "disqualifying" the current LICENSE files.
It should be Brookhaven National Laboratory
Otherwise it should be the normal unmodified license. The modified licenses are from the era before all my meetings with BNL legal. We should change all the non-standard to BSD 3-Clause
I did PRs into a lot of our projects that had no license at all to add the standard license.
It looks like the license in the cookie cutter has been updated, so the first item is done, I also made a new respository and can confirm the second item. I guess it is just the final item updating licenses in existing repositories that needs attention now.
@danielballan and I noticed that GitHub doesn't recognize or label most Bluesky projects as having a BSD 3-Clause license, even though they ship with what we consider a BSD 3-Clause license.
This means they don't get a prominent license tag that identifies the license at the top of the project landing page:
And they also don't get a header providing a quick overview of license features when you view the license file:
Note that this project is correctly recognized. Ophyd, for example, is not.
The reason for this are differences in the LICENSE file, deviating from what GitHub recognizes as a standard BSD 3-Clause license. We think this is worth fixing, as there is both legal and social value in using an established and recognizable license with minimal deviations.
Reference for what GitHub recognizes as standard: BSD 3-Clause
The current LICENSE in this repo matches this exactly, changing only the
[year]
and replacing[fullname]
with "Brookhaven National Laboratory".The current LICENSE in many other NSLS-II and Bluesky repos has the following differences:
BSD 3-Clause License
declaration on line 1Brookhaven Science Associates
as copyright holder in addition toBrookhaven National Laboratory
All rights reserved.
on same line as copyright, instead of its own line below itBrookhaven Science Associates, Brookhaven National Laboratory
as copyright holder, replacing the default reference:the copyright holder
Points 1, 3 and 4 should be straightforward fixes.
Points 2 and 5 require attention.
Once we have answers to the above, the next steps would be:
The text was updated successfully, but these errors were encountered: