From 584093788fd40d19e6533dbdb0ae3f587fb2184d Mon Sep 17 00:00:00 2001 From: Mat Brady Date: Wed, 11 Sep 2019 11:03:33 -0400 Subject: [PATCH] fix: cross-origin links unsafe details https://developers.google.com/web/tools/lighthouse/audits/noopener fix: NUKnightLab/juxtapose/#158 --- juxtapose/js/juxtapose.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/juxtapose/js/juxtapose.js b/juxtapose/js/juxtapose.js index c9cb107..0a103e5 100644 --- a/juxtapose/js/juxtapose.js +++ b/juxtapose/js/juxtapose.js @@ -489,7 +489,8 @@ this.leftImage.appendChild(this.imgBefore.image); this.labCredit = document.createElement("a"); - this.labCredit.setAttribute('href', 'http://juxtapose.knightlab.com'); + this.labCredit.setAttribute('href', 'https://juxtapose.knightlab.com'); + this.labCredit.setAttribute('rel', 'noopener'); this.labCredit.setAttribute('target', '_blank'); this.labCredit.className = 'jx-knightlab'; this.labLogo = document.createElement("div");