Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexplained byte LSL operation for CRC calculation in nusense's dynamixel packetiser.decode() method #19

Open
JohanneMontano opened this issue Jun 29, 2024 · 0 comments

Comments

@JohanneMontano
Copy link
Contributor

https://github.com/NUbots/NUcontroller/blob/main/NUSense/Core/Src/dynamixel/Packetiser.hpp

line 117-118, the read byte is LSL'ed then is put in the packetiser's buffer member. I assumed / expected it to be at least put in the buffer first before being LSL'ed for the length calculation. I tried this with opencr and as expected we encountered a CRC mismatch but for some reason it works with nusense. I believe it must be investigated and explained to prevent ourselves from going insane down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant