Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Fix flower example requirements #3163

Merged
merged 4 commits into from
Jan 23, 2025
Merged

[2.5] Fix flower example requirements #3163

merged 4 commits into from
Jan 23, 2025

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Jan 21, 2025 •
edited by yanchengnv
Loading

Fixes #3128 .

Description

Flower >= 1.13 has breaking changes, pin the version for release.
The integration with the new flower version will come in the next release.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh linked an issue Jan 21, 2025 that may be closed by this pull request
[BUG] Flower versions >=1.13 don't work when running as a FLARE job #3128
Open
@chesterxgchen
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

yanchengnv
yanchengnv approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh YuanTingHsieh merged commit 542b89a into NVIDIA:2.5 Jan 23, 2025
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_flwr_req_25 branch January 23, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv approved these changes

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@holgerroth holgerroth Awaiting requested review from holgerroth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Flower versions >=1.13 don't work when running as a FLARE job
3 participants
@YuanTingHsieh @chesterxgchen @yanchengnv