Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting runtimeClassName #102

Closed
murata-yu opened this issue Sep 20, 2022 · 9 comments
Closed

Allow setting runtimeClassName #102

murata-yu opened this issue Sep 20, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request helm

Comments

@murata-yu
Copy link

murata-yu commented Sep 20, 2022

Hi, there.

In k3s containerd, set runtimeClass to pod without setting default-runtime to use GPU.
We can't set this in helm chart values.
Do you have any plans to change it so that we can set the runtimeClass?

@nikkon-dev
Copy link
Collaborator

@murata-yu,

If I got your question right, you should address this to the nvidia-container-toolkit. The dcgm-exporter does not have control over the runtime - it just needs to see GPUs inside the container, and the way those are visible does not matter.

@murata-yu
Copy link
Author

OK, thanks.

@retsamedoc
Copy link

Er, pushing this off to the nvidia-container-toolkit would require changing the default runtime. Using runtimeClass is more correct and some CNCF kubernetes distros (like k3s) are auto detecting and exposing these 3rd party runtimes this way. Being able to run both runtimes is good from a security perspective (keep the attack vector small whenever possible) while also allowing me to utilize newer features in my other services.

The other tools being used as part of GPU Operator allow for runtimeClass to be set in the values.yaml (and DCGM Exporter will not start due to missing libraries if it is not using the right runtime).

@retsamedoc
Copy link

Er, how was this fixed?

@nvvfedorov
Copy link
Collaborator

Please confirm that the issue still is not resolved.

@nvvfedorov nvvfedorov added enhancement New feature or request helm labels Mar 15, 2024
@nvvfedorov nvvfedorov reopened this Mar 15, 2024
@nvvfedorov
Copy link
Collaborator

@retsamedoc , Please confirm. Do you want to be able to specify runtime in the helm chart?

@retsamedoc
Copy link

Yes. I would like to specify the runtime in the helm chart using the values.yaml similar to the other charts used for GPU operator.

@nvvfedorov
Copy link
Collaborator

@retsamedoc , As I see, today you can specify the runtimeClass when you install the dcgm-exporter with the helm:

{{- if .Values.runtimeClassName }}
.

@nvvfedorov nvvfedorov self-assigned this Mar 18, 2024
@nvvfedorov
Copy link
Collaborator

Done: #291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm
Projects
None yet
Development

No branches or pull requests

4 participants