Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIMLAYERKV #19

Closed
dame-cell opened this issue Nov 28, 2024 · 3 comments · Fixed by #28
Closed

Add SIMLAYERKV #19

dame-cell opened this issue Nov 28, 2024 · 3 comments · Fixed by #28
Assignees
Labels
feature request New feature or request

Comments

@dame-cell
Copy link

dame-cell commented Nov 28, 2024

Feature

SimLayerKV dynamically identifies lazy layers in LLMs—layers that focus primarily on initial and recent tokens allowing selective KV cache trimming. This reduces memory usage during inference without requiring additional training, making it more efficient and adaptive than static methods.

Paper

SimLayerKV
github

not sure if this has been added but if not I would like to work on it

@dame-cell dame-cell added the feature request New feature or request label Nov 28, 2024
@maxjeblick
Copy link
Collaborator

Thanks a lot for opening this issue, this method definitely looks relevant!

I would like to work on it

That would be great! Feel free to ask any questions in this thread. You can also open a draft PR to discuss the current status of the implementation.

@dame-cell
Copy link
Author

awesome I have actually been working on it might open a draft by tomorrow :)
Some questions:

  • Do i need to write a custom tests or just use the existing ones ?

@maxjeblick
Copy link
Collaborator

Do i need to write a custom tests or just use the existing ones ?

In general, any new press should be added here. Apart from that, additional tests are always helpful :)

@dame-cell dame-cell mentioned this issue Dec 3, 2024
@SimJeg SimJeg self-assigned this Dec 4, 2024
@SimJeg SimJeg linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants