Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] add more routines to partition graph #249

Merged
merged 8 commits into from
Dec 15, 2023
Merged

[FEA] add more routines to partition graph #249

merged 8 commits into from
Dec 15, 2023

Conversation

stadlmax
Copy link
Collaborator

@stadlmax stadlmax commented Nov 22, 2023 •
edited
Loading

Modulus Pull Request

Description

  • extends the previous design of GraphPartition which already had more generic partitioning schemes in mind
  • besides the previous "naive" partitioning scheme, this PR now adds support for defining a graph partition by providing
    a mapping for each node ID to a rank
  • based on this, this PR would also add support for using coordinates to define these mapping leveraging domain information to reduce communication between partitions

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

akshaysubr
akshaysubr reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@akshaysubr akshaysubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is very nice! My main comment is that the new partitioning schemes are not tested at the moment. Other than that, only had some minor comments.

modulus/models/gnn_layers/distributed_graph.py Outdated Show resolved Hide resolved
modulus/models/gnn_layers/distributed_graph.py Outdated Show resolved Hide resolved
modulus/models/gnn_layers/distributed_graph.py Show resolved Hide resolved
modulus/models/gnn_layers/distributed_graph.py Outdated Show resolved Hide resolved
modulus/models/gnn_layers/distributed_graph.py Show resolved Hide resolved
modulus/models/gnn_layers/distributed_graph.py Outdated Show resolved Hide resolved
test/models/meshgraphnet/test_meshgraphnet_snmg.py Outdated Show resolved Hide resolved
test/models/graphcast/test_graphcast_snmg.py Show resolved Hide resolved
@stadlmax stadlmax marked this pull request as ready for review December 6, 2023 12:52
@stadlmax stadlmax changed the title [DRAFT] add more routines to partition graph [FEA] add more routines to partition graph Dec 8, 2023
@stadlmax
Copy link
Collaborator Author

stadlmax commented Dec 8, 2023

/blossom-ci

@stadlmax stadlmax requested a review from mnabian December 8, 2023 16:26
@stadlmax stadlmax self-assigned this Dec 12, 2023
@stadlmax stadlmax added enhancement New feature or request 4 - In Review Currently Under Review labels Dec 12, 2023
@NickGeneva
Copy link
Collaborator

/blossom-ci

@stadlmax stadlmax mentioned this pull request Dec 14, 2023
Closed
@NickGeneva
Copy link
Collaborator

/blossom-ci

@akshaysubr
Copy link
Collaborator

/blossom-ci

@mnabian mnabian merged commit b86f60b into NVIDIA:main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaysubr akshaysubr akshaysubr approved these changes

@mnabian mnabian mnabian approved these changes

Assignees

@stadlmax stadlmax

Labels
4 - In Review Currently Under Review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stadlmax @NickGeneva @akshaysubr @mnabian