Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResDiff integration: Switch to Modulus Logging #251

Merged
merged 7 commits into from
Nov 30, 2023
Merged

ResDiff integration: Switch to Modulus Logging #251

merged 7 commits into from
Nov 30, 2023

Conversation

mnabian
Copy link
Collaborator

@mnabian mnabian commented Nov 23, 2023 •
edited
Loading

Modulus Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@mnabian mnabian self-assigned this Nov 23, 2023
@mnabian mnabian added the 3 - Ready for Review Ready for review by team label Nov 23, 2023
@mnabian
Copy link
Collaborator Author

mnabian commented Nov 23, 2023

/blossom-ci

@mnabian mnabian requested a review from NickGeneva November 23, 2023 02:25
@mnabian
Copy link
Collaborator Author

mnabian commented Nov 29, 2023

/blossom-ci

@mnabian
Copy link
Collaborator Author

mnabian commented Nov 29, 2023

/blossom-ci

@mnabian
Copy link
Collaborator Author

mnabian commented Nov 29, 2023

Verified test.sh runs fine with these changes

@mnabian
Copy link
Collaborator Author

mnabian commented Nov 30, 2023

/blossom-ci

@mnabian mnabian merged commit 75ca204 into NVIDIA:main Nov 30, 2023
@mnabian mnabian deleted the enh-ext-logging branch November 30, 2023 03:50
@mnabian mnabian mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexey-Kamenev Alexey-Kamenev Alexey-Kamenev left review comments

@NickGeneva NickGeneva NickGeneva approved these changes

@MortezaMardani MortezaMardani MortezaMardani approved these changes

@daviddpruitt daviddpruitt Awaiting requested review from daviddpruitt

Assignees

@mnabian mnabian

Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnabian @NickGeneva @Alexey-Kamenev @MortezaMardani