Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modular FNO #270

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Modular FNO #270

merged 11 commits into from
Dec 12, 2023

Conversation

mariusaurus
Copy link
Contributor

@mariusaurus mariusaurus commented Dec 6, 2023 •
edited by NickGeneva
Loading

Modulus Pull Request

Description

This MR re-organises the FNO implementation in a modular way and makes encoders for the respective dimension transparent to outside modulus. That way, customisation of FNO is significantly simplified for the user.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@NickGeneva
Copy link
Collaborator

/blossom-ci

@NickGeneva
Copy link
Collaborator

/blossom-ci

ktangsali
ktangsali approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@ktangsali ktangsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left a minor comment about the docstrings. Just to make sure we are getting the same results, let's also verify that the darcy_fno example predictions look good.

modulus/models/fno/fno.py Show resolved Hide resolved
@mariusaurus
Copy link
Contributor Author

just started the darcy_fno example, hasn't finished yet, but after 90 epochs maximum relative error is below 3%

@NickGeneva
Copy link
Collaborator

/blossom-ci

@mariusaurus
Copy link
Contributor Author

just started the darcy_fno example, hasn't finished yet, but after 90 epochs maximum relative error is below 3%

newplot
validation

@NickGeneva
Copy link
Collaborator

/blossom-ci

@NickGeneva NickGeneva merged commit 0cbd09d into NVIDIA:main Dec 12, 2023
@mariusaurus mariusaurus deleted the modular_fno branch December 13, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickGeneva NickGeneva NickGeneva approved these changes

@ktangsali ktangsali ktangsali approved these changes

Assignees

@mariusaurus mariusaurus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariusaurus @NickGeneva @ktangsali