Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Flow-DPM-Solver #110

Open
dxqbYD opened this issue Dec 22, 2024 · 6 comments
Open

Question: Flow-DPM-Solver #110

dxqbYD opened this issue Dec 22, 2024 · 6 comments
Labels
Answered Answered the question

Comments

@dxqbYD
Copy link

dxqbYD commented Dec 22, 2024

Is there already a generic implementation of your Flow-DPM-Solver, such as for Comfy or Swarm?
Would you expect it to work equally well for other flow matching models such as Flux?

thank you

edit: I might have misunderstood your paper. on second read, it sounds like you have adapted DPM to flow matching and compared it to Euler - not proposed a new inference method.

@lawrence-cj
Copy link
Collaborator

Of course. We just adapt DPM to flow matching scheduler and it can works for FLUX with changes. Now the Flow-DPM-Solver is merged into diffusers pipeline.
refer to: https://github.com/huggingface/diffusers/blob/3c2e2aa8a902ebaf57ea36e48a64b52dc9b2e7df/scripts/convert_sana_to_diffusers.py#L232

@lawrence-cj lawrence-cj added the Answered Answered the question label Dec 23, 2024
@dxqbYD
Copy link
Author

dxqbYD commented Dec 23, 2024

thanks for your answer!

I quickly tried it on Flux without changes, and subjectively it does seem to have a lot more sharp details already at around 18 steps compared to Euler.
On the other hand, it seems you cannot really use it for going below 20 steps. For example, DPM at 14 steps isn't close to Euler at 18 but it's still a completely different image.

@lawrence-cj
Copy link
Collaborator

DPM <15 steps will degrade to DDIM. that’s why it doesn’t work. Could you share some comparison results here between Flow DPMS and Euler on FLUX? Curious about it.

@dxqbYD
Copy link
Author

dxqbYD commented Dec 23, 2024

sure
First FlowMatchEulerDiscreteScheduler initialized from Flux's scheduler/.json, second yours initialized from Sana's scheduler/.json
Both 18 steps

image
image

@lawrence-cj
Copy link
Collaborator

I don’t see any difference😂

@dxqbYD
Copy link
Author

dxqbYD commented Dec 23, 2024

I don’t see any difference😂

it's subtle, open in separate tabs and switch
was the difference higher in your Sana tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Answered Answered the question
Projects
None yet
Development

No branches or pull requests

2 participants