Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incentivization: return the reason for the incentivization fail instead of boolean #28

Open
karim-en opened this issue Oct 21, 2021 · 0 comments
Open

Incentivization: return the reason for the incentivization fail instead of boolean #28

karim-en opened this issue Oct 21, 2021 · 0 comments

Comments

@karim-en
Copy link
Collaborator

karim-en commented Oct 21, 2021 •
edited by sept-en
Loading

For the future: perhaps, it makes sense to return the reason why the transaction was not incentivized (instead of boolean):

  • No rules
  • There's a rule, but we are out of the total tokens cap
  • Error,
  • etc.

Originally posted by @sept-en in #21 (comment)
@sept-en sept-en changed the title For the future: perhaps, it makes sense to return the reason why the transaction was not incentivized: Incentivization: return the reason for the incentivization fail instead of boolean Oct 21, 2021
@sept-en sept-en mentioned this issue Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karim-en