Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT connector: use config instead of .env for public data #155

Open
sept-en opened this issue Aug 25, 2022 · 0 comments
Open

FT connector: use config instead of .env for public data #155

sept-en opened this issue Aug 25, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sept-en
Copy link
Contributor

sept-en commented Aug 25, 2022

Currently, deployment and usage of Hardhat scripts for FT connector use .env file as a source for the contract addresses, etc. The .env file is currently in the git, and this could lead to an accidental mistake pushing the private keys/API keys to GitHub. This needs to be changed so:

  • Addresses are used from the config files that are public and tracked;
  • .env file contains only sensitive data: API keys, private keys, etc;
  • .env file is removed from the tracked files.
@sept-en sept-en added the enhancement New feature or request label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants