Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Experimental Class Structure using EEG #196

Closed
Parvfect opened this issue Jul 21, 2022 · 2 comments · Fixed by #184
Closed

Test Experimental Class Structure using EEG #196

Parvfect opened this issue Jul 21, 2022 · 2 comments · Fixed by #184
Assignees

Comments

@Parvfect
Copy link
Collaborator

Parvfect commented Jul 21, 2022

New Experimental class Structure created through #183 has not been tested using an EEG stream. Needs to be rigirously tested using an EEG to make sure that nothing breaks and all other functions work in the same way.

@LIN-DN
Copy link

LIN-DN commented Jul 19, 2023

Have you tested the updated code now? Regarding the visualN170 experiment, the documentation does not appear to have updated the case code. n170.present(duration=record_duration, eeg=eeg_device, save_fn=save_fn) module 'eegnb.experiments.visual_n170.n170' has no attribute 'present'.

@JohnGriffiths
Copy link
Collaborator

Thanks for noting this @LIN-DN . The .present method is now replaced with thenrun method. However it sees the example notebook in the master branch is still showing the old syntax. In the develop branch it is correct.

@oreHGA @tmorshed @Parvfect I think seeing as this is a key documentation file it should be fixed with a direct commit to master rather than waiting for the next merge of develop to master. What do you think? Pls check and confirm I got this correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4 participants