Feat: 메인 식물 리스트 조회 API #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
seohyun-106
commented
Nov 4, 2023
| loveGauge: number; | ||
|
|
||
| // @ApiProperty({description: DTO_RESPONSE_DESCRIPTION.PLANTS.IS_WATERED}) | ||
| // isWatered: boolean; |
There was a problem hiding this comment.
오늘 물을 줬는지 체크하는 isWatered가 DB에서 빠져있어서 우선 주석처리해두었습니다. 추후 수정하겠습니다
seohyun-106
commented
Nov 4, 2023
| @ApiOperation(READ_PLANTS.API_OPERATION) | ||
| @ApiOkResponse( {type: ResponseUserPlantsDto}) | ||
| async getUserPlants(): Promise<ResponseUserPlantsDto> { | ||
| const data = await this.plantsService.getUserPlants(1); |
There was a problem hiding this comment.
Auth 관련 세팅 전이라 userId 임의로 하드코딩해두었습니다. 추후 수정하겠습니다
jokj624
approved these changes
Nov 8, 2023
src/plants/plants.controller.ts
Outdated
| @ApiOperation(READ_PLANTS.API_OPERATION) | ||
| @ApiOkResponse( {type: ResponseUserPlantsDto}) | ||
| async getUserPlants(): Promise<ResponseUserPlantsDto> { | ||
| const data = await this.plantsService.getUserPlants(1); |
There was a problem hiding this comment.
전에 같이 논의했던
유저의 메인 식물 리스트 조회를/plants 가 아니라 /users/userId/plants 로 가는 방향 @junjuning 랑도 한번 논의해보면 좋을 것 같아요.
There was a problem hiding this comment.
| @@ -177,4 +178,84 @@ export class PlantsService { | |||
|
|
|||
| return { reviews: result }; | |||
| } | |||
|
|
|||
| async getUserPlants(userId: number): Promise<ResponseUserPlantsData> { | |||
| const userPlants = await this.prisma.userPlant.findMany({ | |||
There was a problem hiding this comment.
ㅋㅋㅋ ㅠㅠ repository 파일 빼는게 가독성이 10394배는 늘거 같아요 ㅇㅈ?
이건 제가 한번에 다 repository 파일로 빼는 작업 할게요..
added 2 commits
December 17, 2023 19:21
seohyun-106
force-pushed
the
feature/32
branch
from
4242759 to
5a5b82a
Compare
seohyun-106
added a commit
that referenced
this pull request
Dec 17, 2023
* Feat: 식물 카드 상세 조회 API (#33) * Docs: update PR template (add swagger) * Refactor: file name kebab-case 적용 * Feat: plant util 함수 * Feat: plant 상세 조회 API * Docs: update PR template (add checklist) * Feat: plant 상세 조회 service 로직 unit test * Feat: plant 상세 조회 controller unit test * Fix: plants service 로직 time mocking * Feat: env test 환경 설정 * Feat: e2e test 격리된 docker 환경 구축 * Feat: plants e2e test * Feat: 식물 카드 수정 api (#39) * Feat: 식물 카드 수정 api * Feat: 식물 카드 수정 api 상수 파일 * Feat: global exception 에 prisma 에러 처리 추가 * Feat: 식물 카드 수정 테스트 코드 * Feat: 메인 식물 리스트 조회 API (#40) * Feat: 메인 식물 리스트 조회 응닶값 세팅 * Update issue templates * Feat: 메인 화면 랜덤 description 함수 추가 * Chore: Gauge로 통일 * Feat: 메인 식물 리스트 전체 조회 API * Chore: getUserPlants로 함수 이름 변경 * Chore: class 대문자로 변경 * Chore: 프리티어 적용 --------- Co-authored-by: 장서현 <[email protected]> --------- Co-authored-by: Chae Jeong Ah <[email protected]> Co-authored-by: 장서현 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 PR 요약 / Linked Issue
메인 식물 리스트 조회 API입니다
close #32
💡 변경 사항
✅ PR check list