Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR review comments #18

Open
NikMel opened this issue Jan 31, 2025 · 0 comments
Open

Fix PR review comments #18

NikMel opened this issue Jan 31, 2025 · 0 comments
Assignees

Comments

@NikMel
Copy link
Owner

NikMel commented Jan 31, 2025

Fix comments: soundscape-community#134
Remove project file changes

  • Completely remove unrelated changes from PR (entitlements, App name etc). Clean out unrelated changes to the project files in main (main shall be our upstream-tracking branch)
  • There's apparently a change in .storyboard. Is this intentional (no idea what that file is, or why we would have updated it)?
  • There's a change in en_GB-strings (revert)

Physical file location
It seems the code for the Bose-support is placed physically in the root folder and not in a code-folder (probably this is an XCode-thing adding the new files in the wrong place). Move these and make sure it still works...

Fix TODOs and clean out old code

  • apps/ios/GuideDogs/Code/Behaviors/Default/SystemGenerator.swift[112, 114]: Add the string to localization and call GDLocalizedString
  • apps/ios/GuideDogs/BoseFramesBLEDevice.swift[247-274]: Delete commented code
  • apps/ios/GuideDogs/BoseFramesMotionManagerReachability.swift[37-71]: D.o
  • apps/ios/GuideDogs/BoseFramesMotionManagerReachability.swift[97-162]: D:o
  • apps/ios/GuideDogs/BoseSensorDataProcessor.swift[32-52]: D:o
  • apps/ios/GuideDogs/BoseSensorDataProcessor.swift[239-242]: D.o
  • apps/ios/GuideDogs/Code/Visual UI/View Controllers/Devices/DevicesViewController.swift: line 168, replace with a call to GDLocalizationUnnecessary("")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants