Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing includes of some std types #289

Closed
aleasims opened this issue Feb 12, 2024 · 0 comments · Fixed by #290
Closed

Missing includes of some std types #289

aleasims opened this issue Feb 12, 2024 · 0 comments · Fixed by #290
Labels
bug Something isn't working

Comments

@aleasims
Copy link
Contributor

In number of files some includes are missing:

/root/proj/zkllvm/libs/crypto3/libs/zk/include/nil/crypto3/zk/snark/arithmetization/plonk/variable.hpp:170:26: error: no template named 'map' in namespace 'std'; did you mean 'max'?
                    std::map<typename plonk_variable<AssignmentType>::column_type, std::string> type_map = {
                    ~~~~~^~~
                         max
/root/proj/zkllvm/libs/crypto3/libs/zk/include/nil/crypto3/zk/snark/arithmetization/plonk/constraint.hpp:48:30: error: no template named 'map' in namespace 'std'; did you mean 'max'?
                        std::map<std::tuple<std::size_t, int, typename VariableType::column_type>,
                        ~~~~~^~~
                             max

This results in compilation errors, when these files get included.

Of course, user can include these headers on his side, but adding it here seems more sound.

@aleasims aleasims added the bug Something isn't working label Feb 12, 2024
@aleasims aleasims linked a pull request Feb 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant